Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1422193003: UMA for Notification action buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use linear histogram with [0,1) underflow and [17,inf) overflow buckets Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 427a811436f1b009f4bdbdee1a4b3c17c59c8c1a..02f8cd776a05ce9df8b71bdb65471af962ddec0f 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -118,8 +118,13 @@ void PlatformNotificationServiceImpl::OnPersistentNotificationClick(
return;
}
- content::RecordAction(
- base::UserMetricsAction("Notifications.Persistent.Clicked"));
+ if (action_index == -1) {
+ content::RecordAction(base::UserMetricsAction(
+ "Notifications.Persistent.Clicked"));
+ } else {
+ content::RecordAction(base::UserMetricsAction(
+ "Notifications.Persistent.ClickedActionButton"));
+ }
content::NotificationEventDispatcher::GetInstance()
->DispatchNotificationClickEvent(
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698