chrome/browser/notifications/platform_notification_service_impl.cc - Issue 1422193003: UMA for Notification action buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1422193003: UMA for Notification action buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment explaining histogramEnumeration Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index 427a811436f1b009f4bdbdee1a4b3c17c59c8c1a..02f8cd776a05ce9df8b71bdb65471af962ddec0f 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -118,8 +118,13 @@ void PlatformNotificationServiceImpl::OnPersistentNotificationClick(

return;

}

- content::RecordAction(

- base::UserMetricsAction("Notifications.Persistent.Clicked"));

+ if (action_index == -1) {

+ content::RecordAction(base::UserMetricsAction(

+ "Notifications.Persistent.Clicked"));

+ } else {

+ content::RecordAction(base::UserMetricsAction(

+ "Notifications.Persistent.ClickedActionButton"));

+ }

content::NotificationEventDispatcher::GetInstance()

->DispatchNotificationClickEvent(

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »