Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Issue 1422123002: VideoCaptureBufferPool: remove unnecessary |data_| pointers after GpuMemoryBuffer API change (Closed)

Created:
5 years, 1 month ago by mcasas
Modified:
5 years, 1 month ago
Reviewers:
emircan, miu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureBufferPool: remove unnecessary |data_| pointers after GpuMemoryBuffer API change GpuMemoryBufferBufferHandle is a VideoCaputerBufferPool::BufferHandle created from VCBP::GpuMemoryBufferTracker::GpuMemoryBufferTracker(). Previously, the former inherited the data pointer from the latter, but with the recent change in GpuMemoryBuffer API [1], this is not needed anymore. This CL removes the member variable and adapts DCHECK()s in the vicinity. BUG=542225 TEST= All unittests, content_browsertests and browser_tests passing. [1] http://crrev.com/1401183003, relanded as (1412223009). Committed: https://crrev.com/681f844172cf1b945b345f345f1878c6dca02339 Cr-Commit-Position: refs/heads/master@{#356770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 3 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mcasas
miu@ PTAL (corollary follow up of a previous CL, see bug). (ermican@ FYI/PTAL)
5 years, 1 month ago (2015-10-26 23:23:59 UTC) #2
emircan
lgtm
5 years, 1 month ago (2015-10-27 21:31:47 UTC) #5
emircan
lgtm
5 years, 1 month ago (2015-10-27 21:31:49 UTC) #6
miu
lgtm
5 years, 1 month ago (2015-10-29 01:03:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422123002/40001
5 years, 1 month ago (2015-10-29 03:58:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-10-29 05:18:15 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 05:18:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/681f844172cf1b945b345f345f1878c6dca02339
Cr-Commit-Position: refs/heads/master@{#356770}

Powered by Google App Engine
This is Rietveld 408576698