xfa/src/fee/src/fee/fde_txtedtpage.h - Issue 1422113003: Fix XFA compilation noise, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fee/src/fee/fde_txtedtpage.h

Issue 1422113003: Fix XFA compilation noise, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fee/src/fee/fde_txtedtpage.h

diff --git a/xfa/src/fee/src/fee/fde_txtedtpage.h b/xfa/src/fee/src/fee/fde_txtedtpage.h

index 30f717e8bc8a227f730041118c17250d08e3f817..67e2e982b90f7e40a501f06dcd767cc28031df70 100644

--- a/xfa/src/fee/src/fee/fde_txtedtpage.h

+++ b/xfa/src/fee/src/fee/fde_txtedtpage.h

@@ -22,7 +22,7 @@ enum FDE_TXTEDT_CHARTYPE {

FDE_TXTEDT_CHARTYPE_Char,

FDE_TXTEDT_CHARTYPE_CJK,

};

-static FDE_TXTEDT_CHARTYPE FDE_GetEditSelCharType(FX_WCHAR wChar) {

+inline FDE_TXTEDT_CHARTYPE FDE_GetEditSelCharType(FX_WCHAR wChar) {

Lei Zhang 2015/10/31 01:51:42 Seems a bit big to inline. Move impl to .cpp file?

Tom Sepez 2015/11/02 18:03:25 Yeah, followup. For now, get rid of static fn in

if (wChar == 0x9) {

return FDE_TXTEDT_CHARTYPE_Tab;

} else if (wChar == 0x20 || wChar == 0xA0) {