Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.h

Issue 1422113003: Fix XFA compilation noise, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/include/formfiller/FFL_TextField.h ('K') | « fpdfsdk/src/fsdk_baseform.cpp ('k') | xfa/src/fdp/src/tto/fde_textout.h » ('j') | xfa/src/fee/src/fee/fde_txtedtengine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/JS_Runtime.h
diff --git a/fpdfsdk/src/javascript/JS_Runtime.h b/fpdfsdk/src/javascript/JS_Runtime.h
index 4772823d7f2579997973a5729373791894d571f7..0211388293253840e41e36be4000f952ef0c3567 100644
--- a/fpdfsdk/src/javascript/JS_Runtime.h
+++ b/fpdfsdk/src/javascript/JS_Runtime.h
@@ -57,10 +57,10 @@ class CJS_Runtime : public IJS_Runtime {
v8::Isolate* GetIsolate() const { return m_isolate; }
v8::Local<v8::Context> NewJSContext();
- virtual FX_BOOL GetHValueByName(const CFX_ByteStringC& utf8Name,
- FXJSE_HVALUE hValue);
- virtual FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name,
- FXJSE_HVALUE hValue);
+ FX_BOOL GetHValueByName(const CFX_ByteStringC& utf8Name,
Lei Zhang 2015/10/31 02:03:20 Add // IJS_Runtime:
Tom Sepez 2015/11/02 18:03:25 Done.
+ FXJSE_HVALUE hValue) override;
+ FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name,
+ FXJSE_HVALUE hValue) override;
void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer);
« fpdfsdk/include/formfiller/FFL_TextField.h ('K') | « fpdfsdk/src/fsdk_baseform.cpp ('k') | xfa/src/fdp/src/tto/fde_textout.h » ('j') | xfa/src/fee/src/fee/fde_txtedtengine.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698