Fix XFA compilation noise, part 1.

fpdfsdk/src/fpdfsave.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../public/fpdf_edit.h"
 #include "../../public/fpdf_formfill.h"
 #include "../../public/fpdf_save.h"
 #include "../include/fsdk_define.h"
@@ skipping 117 matching lines @@
     pContext->UpdateChecksum((IFX_FileRead*)pTemplate);
     pTemplate->Release();
   }
 #endif
   CPDF_Stream* pFormStream = NULL;
   CPDF_Stream* pDataSetsStream = NULL;
   if (iFormIndex != -1) {
     // Get form CPDF_Stream
     CPDF_Object* pFormPDFObj = pArray->GetElement(iFormIndex);
     if (pFormPDFObj->GetType() == PDFOBJ_REFERENCE) {
-      CPDF_Reference* pFormRefObj = (CPDF_Reference*)pFormPDFObj;
       CPDF_Object* pFormDircetObj = pFormPDFObj->GetDirect();
       if (NULL != pFormDircetObj &&
           pFormDircetObj->GetType() == PDFOBJ_STREAM) {
         pFormStream = (CPDF_Stream*)pFormDircetObj;
       }
     } else if (pFormPDFObj->GetType() == PDFOBJ_STREAM) {
       pFormStream = (CPDF_Stream*)pFormPDFObj;
     }
   }
 
@@ skipping 29 matching lines @@
       pContext->UpdateChecksum((IFX_FileRead*)pDsfileWrite);
       pContext->FinishChecksum();
 #endif
       CPDF_Dictionary* pDataDict = new CPDF_Dictionary;
       if (iDataSetsIndex != -1) {
         if (pDataSetsStream)
           pDataSetsStream->InitStream(pDsfileWrite, pDataDict);
       } else {
         CPDF_Stream* pData = new CPDF_Stream(NULL, 0, NULL);
         pData->InitStream(pDsfileWrite, pDataDict);
-        FX_DWORD AppStreamobjnum = pPDFDocument->AddIndirectObject(pData);
-        CPDF_Reference* pRef =
-            (CPDF_Reference*)pPDFDocument->GetIndirectObject(AppStreamobjnum);
-        {
-          iLast = pArray->GetCount() - 2;
-          pArray->InsertAt(iLast, CPDF_String::Create("datasets"));
-          pArray->InsertAt(iLast + 1, pData, pPDFDocument);
-        }
+        pPDFDocument->AddIndirectObject(pData);
+        iLast = pArray->GetCount() - 2;
+        pArray->InsertAt(iLast, CPDF_String::Create("datasets"));
+        pArray->InsertAt(iLast + 1, pData, pPDFDocument);
       }
       fileList.Add(pDsfileWrite);
     }
   }
 
   // L"form"
   {
     IFX_FileStream* pfileWrite = FX_CreateMemoryStream();
     if (NULL == pfileWrite) {
       pContext->Release();
       return FALSE;
     }
     if (pXFADocHandler->SavePackage(pXFADocView->GetDoc(),
                                     CFX_WideStringC(L"form"), pfileWrite,
                                     pContext) &&
         pfileWrite > 0) {
       CPDF_Dictionary* pDataDict = new CPDF_Dictionary;
       if (iFormIndex != -1) {
         if (pFormStream)
           pFormStream->InitStream(pfileWrite, pDataDict);
       } else {
         CPDF_Stream* pData = new CPDF_Stream(NULL, 0, NULL);
         pData->InitStream(pfileWrite, pDataDict);
-        FX_DWORD AppStreamobjnum = pPDFDocument->AddIndirectObject(pData);
-        CPDF_Reference* pRef =
-            (CPDF_Reference*)pPDFDocument->GetIndirectObject(AppStreamobjnum);
-        {
-          iLast = pArray->GetCount() - 2;
-          pArray->InsertAt(iLast, CPDF_String::Create("form"));
-          pArray->InsertAt(iLast + 1, pData, pPDFDocument);
-        }
+        pPDFDocument->AddIndirectObject(pData);
+        iLast = pArray->GetCount() - 2;
+        pArray->InsertAt(iLast, CPDF_String::Create("form"));
+        pArray->InsertAt(iLast + 1, pData, pPDFDocument);
       }
       fileList.Add(pfileWrite);
     }
   }
   pContext->Release();
 #endif  // PDF_ENABLE_XFA
 
   return TRUE;
 }
 
@@ skipping 99 matching lines @@
                                             FPDF_DWORD flags) {
   return _FPDF_Doc_Save(document, pFileWrite, flags, FALSE, 0);
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_SaveWithVersion(FPDF_DOCUMENT document,
                                                  FPDF_FILEWRITE* pFileWrite,
                                                  FPDF_DWORD flags,
                                                  int fileVersion) {
   return _FPDF_Doc_Save(document, pFileWrite, flags, TRUE, fileVersion);
 }