Enable pcm_s32le audio decoding.

Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

BUG=557170
,internal b/22378279
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed

Committed: https://crrev.com/ad33ab7a20ddede811d0562c45a267a1b06c1ed6
Cr-Commit-Position: refs/heads/master@{#361545}

[jyw, 2015-10-26 22:35:10]

Description was changed from

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

Change-Id: I77b4650e25d91523952f8a7eb7a335d56c5eb703

Bug: internal http://b/22378279

BUG=
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

to

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

Change-Id: I77b4650e25d91523952f8a7eb7a335d56c5eb703

Bug: internal http://b/22378279

BUG=
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

[jyw, 2015-10-26 22:35:10]

jyw@chromium.org changed reviewers:
+ dalecurtis@google.com

[DaleCurtis, 2015-11-18 01:21:34]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org
- dalecurtis@google.com

[DaleCurtis, 2015-11-18 01:25:35]

lgtm

[DaleCurtis, 2015-11-18 01:25:44]

Needs a DEPS update though

[halliwell, 2015-11-18 01:27:43]

On 2015/11/18 01:25:44, DaleCurtis wrote:
> Needs a DEPS update though

Commit message nits:
* Remove gerrit Change-Id
* Remove gerrit-syntax Bug: line
* Put internal bug link after BUG=

Not sure if the TEST details are necessary ... CQ will run all unit tests ;)

[jyw, 2015-11-20 01:05:40]

On 2015/11/18 01:25:44, DaleCurtis wrote:
> Needs a DEPS update though

Looks like there was a DEPS update after the corresponding third_party/ffmpeg
change.

[jyw, 2015-11-20 01:06:20]

On 2015/11/18 01:27:43, halliwell wrote:
> On 2015/11/18 01:25:44, DaleCurtis wrote:
> > Needs a DEPS update though
> 
> Commit message nits:
> * Remove gerrit Change-Id
> * Remove gerrit-syntax Bug: line
> * Put internal bug link after BUG=
> 
> Not sure if the TEST details are necessary ... CQ will run all unit tests ;)

Done, and I figure the TEST details can't hurt :)

[halliwell, 2015-11-20 03:48:20]

On 2015/11/20 01:06:20, jyw wrote:
> On 2015/11/18 01:27:43, halliwell wrote:
> > On 2015/11/18 01:25:44, DaleCurtis wrote:
> > > Needs a DEPS update though
> > 
> > Commit message nits:
> > * Remove gerrit Change-Id
> > * Remove gerrit-syntax Bug: line
> > * Put internal bug link after BUG=
> > 
> > Not sure if the TEST details are necessary ... CQ will run all unit tests ;)
> 
> Done, and I figure the TEST details can't hurt :)

It doesn't look like the commit message is updated (it's not like gerrit, you
have to edit it here in the code review UI).

[jyw, 2015-11-20 17:24:59]

Description was changed from

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

Change-Id: I77b4650e25d91523952f8a7eb7a335d56c5eb703

Bug: internal http://b/22378279

BUG=
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

to

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

BUG=557170, internal b/22378279
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

[jyw, 2015-11-20 17:39:11]

Description was changed from

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

BUG=557170, internal b/22378279
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

to

==========
Enable pcm_s32le audio decoding.

To accomodate this change, a new kSampleFormatS24 has been introduced.
It is only used with S24LE PCM input. FFmpeg treats pcm_s24le as an
encoded format that can be decoded into s32le samples; kSampleFormatS24
only exists on the Chrome side to distinguish FFmpeg's pcm_s24le from
pcm_s32le, both of which use Chrome's catch-all kCodecPCM codec and
the same real sample format.

BUG=557170,internal b/22378279
TEST=media_unittests --gtest_filter=AudioBufferTest.*
media_unittests --gtest_filter=PipelineIntegrationTest.S32PlaybackHashed
==========

[jyw, 2015-11-21 01:27:16]

The CQ bit was checked by jyw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-21 01:28:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/20001

[commit-bot: I haz the power, 2015-11-21 01:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 01:50:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jyw, 2015-11-21 02:11:40]

The CQ bit was checked by jyw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-21 02:12:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/40001

[commit-bot: I haz the power, 2015-11-21 02:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 02:40:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jyw, 2015-11-23 18:19:07]

The CQ bit was checked by jyw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 18:20:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/60001

[commit-bot: I haz the power, 2015-11-23 18:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 18:31:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jyw, 2015-11-23 20:06:25]

The CQ bit was checked by jyw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 20:09:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/80001

[commit-bot: I haz the power, 2015-11-23 20:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 20:48:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[halliwell, 2015-11-23 22:55:06]

On 2015/11/23 20:48:47, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

chromecast/ lgtm

[jyw, 2015-11-24 00:39:24]

The CQ bit was checked by jyw@chromium.org

[jyw, 2015-11-24 00:39:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1422113002/#ps100001
(title: "more clang-format")

[commit-bot: I haz the power, 2015-11-24 00:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/100001

[commit-bot: I haz the power, 2015-11-24 02:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 02:56:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jyw, 2015-11-24 22:39:25]

The CQ bit was checked by jyw@chromium.org

[jyw, 2015-11-24 22:39:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1422113002/#ps120001
(title: "this time with the right version of clang-format-diff.py")

[commit-bot: I haz the power, 2015-11-24 22:41:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/120001

[ddorwin, 2015-11-24 23:13:38]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2015-11-24 23:13:39]

The current FFmpeg DEPS is missing some related changes. See
https://chromium-review.googlesource.com/#/c/314321/. I don't know if those
actually get used anywhere.

[jyw, 2015-11-24 23:39:59]

The CQ bit was unchecked by jyw@chromium.org

[ddorwin, 2015-11-25 00:21:43]

DEPS LGTM

[jyw, 2015-11-25 00:22:58]

The CQ bit was checked by jyw@chromium.org

[jyw, 2015-11-25 00:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1422113002/#ps140001
(title: "DEPS roll")

[commit-bot: I haz the power, 2015-11-25 00:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422113002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422113002/140001

[commit-bot: I haz the power, 2015-11-25 03:21:03]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-25 03:23:03]

Patchset 8 (id:??) landed as
https://crrev.com/ad33ab7a20ddede811d0562c45a267a1b06c1ed6
Cr-Commit-Position: refs/heads/master@{#361545}