cc: Remove the ability to specify a GL texture target

cc/resources/resource_pool.h

Index: cc/resources/resource_pool.h
diff --git a/cc/resources/resource_pool.h b/cc/resources/resource_pool.h
index c1db254e052e78627fdcb791aa01f528a69b1177..b926c41362f3117c44224f3316415ad37152e444 100644
--- a/cc/resources/resource_pool.h
+++ b/cc/resources/resource_pool.h
@@ -21,20 +21,18 @@ namespace cc {
 
 class CC_EXPORT ResourcePool : public base::trace_event::MemoryDumpProvider {
  public:
-  static scoped_ptr<ResourcePool> Create(
+  static scoped_ptr<ResourcePool> CreateForImageTextureTarget(

[reveman, 2015/10/29 14:11:39]

I think this change will break the ongoing work to support compressed tile
textures as we need a mix of texture targets in that case. Some tiles will be
compressed and some will not. E.g. the driver might only support compression
opaque contents.

[ccameron, 2015/10/29 19:08:29]

Is there a reason that the texture target selection cannot be pushed down to the
ResourceProvider level?

If we are planning to have the ResourceProvider have a flag saying "make all of
the texture backed by native GMBs", then it will be necessary to never specify a
texture target, because the choice of texture target is already fixed by the
decision to use GMBs.

IMO, the ResourceProvider's interface should be renderer-agnostic, and the GL
texture target is very non-renderer-agnostic.

[reveman, 2015/10/29 19:41:57]

There are some plans to allocate resources on worker threads instead of the
compositor thread and that wouldn't really allow us to use the RP. I don't think
there's any reason it couldn't be pushed down to RP in ToT though.
I agree. ResourcePool should be render agnostic too. 

       ResourceProvider* resource_provider,
       base::SingleThreadTaskRunner* task_runner) {
     return make_scoped_ptr(
-        new ResourcePool(resource_provider, task_runner, 0 /* target */));
+        new ResourcePool(resource_provider, task_runner, true));
   }
 
   static scoped_ptr<ResourcePool> Create(
       ResourceProvider* resource_provider,
-      base::SingleThreadTaskRunner* task_runner,
-      GLenum target) {
-    DCHECK_NE(0u, target);
+      base::SingleThreadTaskRunner* task_runner) {
     return make_scoped_ptr(
-        new ResourcePool(resource_provider, task_runner, target));
+        new ResourcePool(resource_provider, task_runner, false));
   }
 
   ~ResourcePool() override;
@@ -72,7 +70,7 @@ class CC_EXPORT ResourcePool : public base::trace_event::MemoryDumpProvider {
  protected:
   ResourcePool(ResourceProvider* resource_provider,
                base::SingleThreadTaskRunner* task_runner,
-               GLenum target);
+               bool use_image_texture_target);
 
   bool ResourceUsageTooHigh();
 
@@ -111,7 +109,7 @@ class CC_EXPORT ResourcePool : public base::trace_event::MemoryDumpProvider {
   base::TimeTicks GetUsageTimeForLRUResource() const;
 
   ResourceProvider* resource_provider_;
-  const GLenum target_;
+  bool use_image_texture_target_;
   size_t max_memory_usage_bytes_;
   size_t max_resource_count_;
   size_t in_use_memory_usage_bytes_;