cc: Remove the ability to specify a GL texture target

cc/resources/resource_provider.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/resource_provider.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/atomic_sequence_num.h"
@@ skipping 381 matching lines @@
                              format);
     case RESOURCE_TYPE_BITMAP:
       DCHECK_EQ(RGBA_8888, format);
       return CreateBitmap(size);
   }
 
   LOG(FATAL) << "Invalid default resource type.";
   return 0;
 }
 
-ResourceId ResourceProvider::CreateResourceWithTextureTarget(
+ResourceId ResourceProvider::CreateResourceWithImageTextureTarget(
     const gfx::Size& size,
-    GLenum target,
     TextureHint hint,
     ResourceFormat format) {
   DCHECK(!size.IsEmpty());
+  GLenum target = GetImageTextureTarget(format);

[reveman, 2015/10/29 19:41:58]

Can we move this into the RESOURCE_TYPE_GL_TEXTURE case below and simply
s/target/GetImageTextureTarget(format)/ ?

[ccameron, 2015/10/29 20:01:29]

You're right.

+  if (!target)

[reveman, 2015/10/29 19:41:57]

is this still needed?

[ccameron, 2015/10/29 20:01:29]

Nope -- removed.

+    target = GL_TEXTURE_2D;
   switch (default_resource_type_) {
     case RESOURCE_TYPE_GL_TEXTURE:
       return CreateGLTexture(size,
                              target,
                              hint,
                              format);
     case RESOURCE_TYPE_BITMAP:
       DCHECK_EQ(RGBA_8888, format);
       return CreateBitmap(size);
   }
@@ skipping 1222 matching lines @@
       const int kImportance = 2;
       pmd->CreateSharedGlobalAllocatorDump(guid);
       pmd->AddOwnershipEdge(dump->guid(), guid, kImportance);
     }
   }
 
   return true;
 }
 
 }  // namespace cc