permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

Queue controller is a class which is almost 6 years old and its age is
starting to show. It uses all sorts of interesting hacks to tie request
lifecycles to the lifecycle of a web contents.

Moreover, coallescing permissions would be a nightmare since the request
id is compared and all sorts of strange checks are used to compare
request
equality.

Instead of all the craziness, just rewrite the controller to be a
version
of bubble manager for infobars. This leads to far simpler code as the
manager as a whole is tied to a web contents so we get lifecycle
management
for free!

Furthermore, we also have multiple permisisons managed and coallesced
for when it is implemented.

This CL is also a part of a group of CLs:
(1) https://codereview.chromium.org/1332293002
(2) https://codereview.chromium.org/1337903002 (this)
(3) https://codereview.chromium.org/1332063003

BUG=516626

[Lalit Maganti (personal), 2015-10-26 21:00:33]

lalitmaganti@gmail.com changed reviewers:
+ mlamouri@chromium.org

[Lalit Maganti (personal), 2015-10-26 21:00:34]

Mounir: rebasing was a pain with the ifdef change but should be good now. I
can't run the trybots myself to debug the failing Android test however :/

Also I've noticed that someone is working on replacing ContentSettingsType ->
PermissionType which should get rid of a TODO in this patch.

[mlamouri (slow - plz ping), 2015-10-26 22:23:34]

Lalit, as you might imagine, I've been working on this CL after the other
permission CL. Unfortunately, after rebasing, I saw that the CL was failing a
lot of unit tests and I found a crash. I'm still working on fixing the tests.
I'm afraid you will have a hard time to work on this if you can't run the tests
locally and this has become a priority for us.

[Lalit Maganti (personal), 2015-10-26 23:17:05]

Ah OK. Yeah I understand. I'll just watch on as an observer in that case :)

[Lalit Maganti (personal), 2015-10-26 23:17:16]

Description was changed from

==========
permissions: remove PermissionQueueController and introduce
PermissionInfoBarManager

Queue controller is a class which is almost 6 years old and its age is
starting to show. It uses all sorts of interesting hacks to tie request
lifecycles to the lifecycle of a web contents.

Moreover, coallescing permissions would be a nightmare since the request
id is compared and all sorts of strange checks are used to compare
request
equality.

Instead of all the craziness, just rewrite the controller to be a
version
of bubble manager for infobars. This leads to far simpler code as the
manager as a whole is tied to a web contents so we get lifecycle
management
for free!

Furthermore, we also have multiple permisisons managed and coallesced
for when it is implemented.

This CL is also a part of a group of CLs:
(1) https://codereview.chromium.org/1332293002
(2) https://codereview.chromium.org/1337903002 (this)
(3) https://codereview.chromium.org/1332063003

BUG=516626
==========

to

==========
permissions: remove PermissionQueueController and introduce
PermissionInfoBarManager

Queue controller is a class which is almost 6 years old and its age is
starting to show. It uses all sorts of interesting hacks to tie request
lifecycles to the lifecycle of a web contents.

Moreover, coallescing permissions would be a nightmare since the request
id is compared and all sorts of strange checks are used to compare
request
equality.

Instead of all the craziness, just rewrite the controller to be a
version
of bubble manager for infobars. This leads to far simpler code as the
manager as a whole is tied to a web contents so we get lifecycle
management
for free!

Furthermore, we also have multiple permisisons managed and coallesced
for when it is implemented.

This CL is also a part of a group of CLs:
(1) https://codereview.chromium.org/1332293002
(2) https://codereview.chromium.org/1337903002 (this)
(3) https://codereview.chromium.org/1332063003

BUG=516626
==========