Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 1422043007: Revert of Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed)

Created:
5 years, 1 month ago by carlosk
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (patchset #37 id:900001 of https://codereview.chromium.org/1352813006/ ) Reason for revert: Due to crashes in RenderFrameHostManager::CheckWebUITransition. Original issue's description: > Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. > > This change refactors the current ownership of the WebUI instance, > moving it from the RenderFrameHostManager to the RenderFrameHost which > is directly associated with the WebUI. > > The design document for this change is here: > https://docs.google.com/a/chromium.org/document/d/1jrge5ulZ1YtqSR3WkNXzrtxhd3JXcWm8_zWBhEjaJtI > > BUG=508850 > > Committed: https://crrev.com/e5c678bf5b084988a60a4636342414f2831c1695 > Cr-Commit-Position: refs/heads/master@{#358050} TBR=clamy@chromium.org,nasko@chromium.org,creis@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508850 Committed: https://crrev.com/795f1b299c6f5900c12495f972a0c62d2c963419 Cr-Commit-Position: refs/heads/master@{#358297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -346 lines) Patch
M content/browser/frame_host/frame_tree.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 5 chunks +0 lines, -25 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 7 chunks +0 lines, -72 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 13 chunks +88 lines, -44 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 28 chunks +197 lines, -167 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
carlosk
Created Revert of Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.
5 years, 1 month ago (2015-11-06 10:33:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422043007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422043007/1
5 years, 1 month ago (2015-11-06 10:33:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 10:34:21 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 10:35:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/795f1b299c6f5900c12495f972a0c62d2c963419
Cr-Commit-Position: refs/heads/master@{#358297}

Powered by Google App Engine
This is Rietveld 408576698