chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html - Issue 1422023012: MD Settings: Simplify settings-dropdown-menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html

Issue 1422023012: MD Settings: Simplify settings-dropdown-menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | chrome/browser/resources/settings/controls/compiled_resources.gyp » ('j') | chrome/browser/resources/settings/controls/settings_dropdown_menu.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html

diff --git a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html

index 398eb62f40b10617d80eedca621497cd7f93756f..263f0a4337646ccb754951690b327d15dd1f4471 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html

+++ b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html

@@ -15,7 +15,7 @@

<settings-dropdown-menu id="clearFrom"

pref="{{prefs.browser.clear_data.time_period}}"

- menuOptions="[[clearFromOptions_]]" disabled>

+ menu-options="[[clearFromOptions_]]" disabled>

stevenjb 2015/11/11 02:04:21 Can we remove 'disabled' here?

</settings-dropdown-menu>

</div>