chrome/browser/resources/settings/controls/settings_dropdown_menu.html - Issue 1422023012: MD Settings: Simplify settings-dropdown-menu

Side by Side Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 1422023012: MD Settings: Simplify settings-dropdown-menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html ('K') | « chrome/browser/resources/settings/controls/compiled_resources.gyp ('k') | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">

5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">	5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	6 <link rel="import" href="chrome://md-settings/prefs/selectable_pref_behavior.htm l">

6	7

7 <dom-module id="settings-dropdown-menu">	8 <dom-module id="settings-dropdown-menu">

8 <link rel="import" type="css"	9 <link rel="import" type="css"

9 href="chrome://md-settings/settings_page/settings_page.css">	10 href="chrome://md-settings/settings_page/settings_page.css">

10 <template>	11 <template>

11 <paper-dropdown-menu id="dropdownMenu"	12 <paper-dropdown-menu id="dropdownMenu" label="[[menuLabel_]]"

12 label="[[menuLabel_]]" disabled>	13 on-iron-select="onSelect_" disabled="[[disabled]]">
	dschuyler 2015/11/13 00:11:16 If we're not disabling the menus while loading, is If we're not disabling the menus while loading, is the disabled necessary? michaelpg 2015/11/13 00:33:08 I'm exposing disabled as a property, like we do fo Show quoted text On 2015/11/13 00:11:16, dschuyler wrote: > If we're not disabling the menus while loading, is the disabled necessary? I'm exposing disabled as a property, like we do for settings-input and settings-checkbox. So the host can set a dropdown menu to disabled and that passes thru to the <paper-dropdown-menu>.
13 <paper-menu class="dropdown-content" selected="{{selected_}}">	14 <paper-menu class="dropdown-content" selected="{{selected_}}"

	15 attr-for-selected="data-value">

14 <template is="dom-repeat" items="[[menuOptions]]">	16 <template is="dom-repeat" items="[[menuOptions]]">

15 <paper-item>[[item.1]]</paper-item>	17 <paper-item data-value$="[[item.0]]">[[item.1]]</paper-item>

16 </template>	18 </template>

17 <template is="dom-if" if="[[showNotFoundValue_]]">	19 <template is="dom-if" if="[[showNotFoundValue_]]">

18 <paper-item>[[i18n('custom')]]</paper-item>	20 <paper-item data-value$="[[notFoundItem_.0]]">

	21 [[notFoundItem_.1]]

	22 </paper-item>

19 </template>	23 </template>

20 </paper-menu>	24 </paper-menu>

21 </paper-dropdown-menu>	25 </paper-dropdown-menu>

22 </template>	26 </template>

23 <script src="settings_dropdown_menu.js"></script>	27 <script src="settings_dropdown_menu.js"></script>

24 </dom-module>	28 </dom-module>

OLD	NEW