Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: util/win/registration_protocol_win.h

Issue 1422023010: win: Use signed int as the integer representation of HANDLEs (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« util/win/handle.h ('K') | « util/win/process_info_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/registration_protocol_win.h
diff --git a/util/win/registration_protocol_win.h b/util/win/registration_protocol_win.h
index f2d9e29cfd5b9fad09bab68ed0cc6a99269ed09b..c57c6e20544a8a0baea3a85e35be80ff7745aa1f 100644
--- a/util/win/registration_protocol_win.h
+++ b/util/win/registration_protocol_win.h
@@ -92,22 +92,22 @@ struct ClientToServerMessage {
};
};
-//! \brief A client registration response.
+//! \brief A client registration response.
struct RegistrationResponse {
//! \brief An event `HANDLE`, valid in the client process, that should be
- //! signaled to request a crash report. 64-bit clients should convert the
- //! value to a `HANDLE` using sign-extension.
- uint32_t request_crash_dump_event;
+ //! signaled to request a crash report. Clients should convert the value
+ //! to a `HANDLE` by calling IntToHandle().
+ int request_crash_dump_event;
//! \brief An event `HANDLE`, valid in the client process, that should be
- //! signaled to request a non-crashing dump be taken. 64-bit clients
- //! should convert the value to `HANDLEEE` using sign-extension.
- uint32_t request_non_crash_dump_event;
+ //! signaled to request a non-crashing dump be taken. Clients should
+ //! convert the value to a `HANDLE` by calling IntToHandle().
+ int request_non_crash_dump_event;
//! \brief An event `HANDLE`, valid in the client process, that will be
- //! signaled by the server when the non-crashing dump is complete. 64-bit
- //! clients should convert the value to `HANDLEEE` using sign-extension.
scottmg 2015/11/06 18:33:22 EEEE!
- uint32_t non_crash_dump_completed_event;
+ //! signaled by the server when the non-crashing dump is complete. Clients
+ //! should convert the value to a `HANDLE` by calling IntToHandle().
+ int non_crash_dump_completed_event;
};
//! \brief The response sent back to the client via SendToCrashHandlerServer().
« util/win/handle.h ('K') | « util/win/process_info_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698