Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: util/win/registration_protocol_win.h

Issue 1422023010: win: Use signed int as the integer representation of HANDLEs (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« util/win/handle.h ('K') | « util/win/process_info_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 //! \brief For ShutdownRequest. 85 //! \brief For ShutdownRequest.
86 kShutdown, 86 kShutdown,
87 } type; 87 } type;
88 88
89 union { 89 union {
90 RegistrationRequest registration; 90 RegistrationRequest registration;
91 ShutdownRequest shutdown; 91 ShutdownRequest shutdown;
92 }; 92 };
93 }; 93 };
94 94
95 //! \brief A client registration response. 95 //! \brief A client registration response.
96 struct RegistrationResponse { 96 struct RegistrationResponse {
97 //! \brief An event `HANDLE`, valid in the client process, that should be 97 //! \brief An event `HANDLE`, valid in the client process, that should be
98 //! signaled to request a crash report. 64-bit clients should convert the 98 //! signaled to request a crash report. Clients should convert the value
99 //! value to a `HANDLE` using sign-extension. 99 //! to a `HANDLE` by calling IntToHandle().
100 uint32_t request_crash_dump_event; 100 int request_crash_dump_event;
101 101
102 //! \brief An event `HANDLE`, valid in the client process, that should be 102 //! \brief An event `HANDLE`, valid in the client process, that should be
103 //! signaled to request a non-crashing dump be taken. 64-bit clients 103 //! signaled to request a non-crashing dump be taken. Clients should
104 //! should convert the value to `HANDLEEE` using sign-extension. 104 //! convert the value to a `HANDLE` by calling IntToHandle().
105 uint32_t request_non_crash_dump_event; 105 int request_non_crash_dump_event;
106 106
107 //! \brief An event `HANDLE`, valid in the client process, that will be 107 //! \brief An event `HANDLE`, valid in the client process, that will be
108 //! signaled by the server when the non-crashing dump is complete. 64-bit 108 //! signaled by the server when the non-crashing dump is complete. Clients
109 //! clients should convert the value to `HANDLEEE` using sign-extension. 109 //! should convert the value to a `HANDLE` by calling IntToHandle().
scottmg 2015/11/06 18:33:22 EEEE!
110 uint32_t non_crash_dump_completed_event; 110 int non_crash_dump_completed_event;
111 }; 111 };
112 112
113 //! \brief The response sent back to the client via SendToCrashHandlerServer(). 113 //! \brief The response sent back to the client via SendToCrashHandlerServer().
114 union ServerToClientMessage { 114 union ServerToClientMessage {
115 RegistrationResponse registration; 115 RegistrationResponse registration;
116 }; 116 };
117 117
118 #pragma pack(pop) 118 #pragma pack(pop)
119 119
120 //! \brief Connect over the given \a pipe_name, passing \a message to the 120 //! \brief Connect over the given \a pipe_name, passing \a message to the
121 //! server, storing the server's reply into \a response. 121 //! server, storing the server's reply into \a response.
122 //! 122 //!
123 //! Typically clients will not use this directly, instead using 123 //! Typically clients will not use this directly, instead using
124 //! CrashpadClient::SetHandler(). 124 //! CrashpadClient::SetHandler().
125 //! 125 //!
126 //! \sa CrashpadClient::SetHandler() 126 //! \sa CrashpadClient::SetHandler()
127 bool SendToCrashHandlerServer(const base::string16& pipe_name, 127 bool SendToCrashHandlerServer(const base::string16& pipe_name,
128 const ClientToServerMessage& message, 128 const ClientToServerMessage& message,
129 ServerToClientMessage* response); 129 ServerToClientMessage* response);
130 130
131 } // namespace crashpad 131 } // namespace crashpad
132 132
133 #endif // CRASHPAD_UTIL_WIN_REGISTRATION_PROTOCOL_WIN_H_ 133 #endif // CRASHPAD_UTIL_WIN_REGISTRATION_PROTOCOL_WIN_H_
OLDNEW
« util/win/handle.h ('K') | « util/win/process_info_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698