win: Use signed int as the integer representation of HANDLEs

util/win/process_info_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 558 matching lines @@
                                                mapping_name.c_str()));
   ASSERT_TRUE(mapping.is_valid()) << ErrorMessage("CreateFileMapping");
 
   ProcessInfo info;
   info.Initialize(GetCurrentProcess());
   bool found_file_handle = false;
   bool found_inherited_file_handle = false;
   bool found_key_handle = false;
   bool found_mapping_handle = false;
   for (auto handle : info.Handles()) {
-    const int handle_int = implicit_cast<int>(handle.handle);
-    if (handle_int == HandleToInt(file.get())) {
+    if (handle.handle == HandleToInt(file.get())) {
       EXPECT_FALSE(found_file_handle);
       found_file_handle = true;
       EXPECT_EQ(L"File", handle.type_name);
       EXPECT_EQ(1, handle.handle_count);
       EXPECT_NE(0u, handle.pointer_count);
       EXPECT_EQ(STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE | SYNCHRONIZE,
                 handle.granted_access & STANDARD_RIGHTS_ALL);
       EXPECT_EQ(0, handle.attributes);
     }
-    if (handle_int == HandleToInt(inherited_file.get())) {
+    if (handle.handle == HandleToInt(inherited_file.get())) {
       EXPECT_FALSE(found_inherited_file_handle);
       found_inherited_file_handle = true;
       EXPECT_EQ(L"File", handle.type_name);
       EXPECT_EQ(1, handle.handle_count);
       EXPECT_NE(0u, handle.pointer_count);
       EXPECT_EQ(STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE | SYNCHRONIZE,
                 handle.granted_access & STANDARD_RIGHTS_ALL);
 
       // OBJ_INHERIT from ntdef.h, but including that conflicts with other
       // headers.
       const int kObjInherit = 0x2;
       EXPECT_EQ(kObjInherit, handle.attributes);
     }
-    if (handle_int == HandleToInt(scoped_key.get())) {
+    if (handle.handle == HandleToInt(scoped_key.get())) {
       EXPECT_FALSE(found_key_handle);
       found_key_handle = true;
       EXPECT_EQ(L"Key", handle.type_name);
       EXPECT_EQ(1, handle.handle_count);
       EXPECT_NE(0u, handle.pointer_count);
       EXPECT_EQ(STANDARD_RIGHTS_READ,
                 handle.granted_access & STANDARD_RIGHTS_ALL);
       EXPECT_EQ(0, handle.attributes);
     }
-    if (handle_int == HandleToInt(mapping.get())) {
+    if (handle.handle == HandleToInt(mapping.get())) {
       EXPECT_FALSE(found_mapping_handle);
       found_mapping_handle = true;
       EXPECT_EQ(L"Section", handle.type_name);
       EXPECT_EQ(1, handle.handle_count);
       EXPECT_NE(0u, handle.pointer_count);
       EXPECT_EQ(DELETE | READ_CONTROL | WRITE_DAC | WRITE_OWNER |
                     STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE,
                 handle.granted_access & STANDARD_RIGHTS_ALL);
       EXPECT_EQ(0, handle.attributes);
     }
@@ skipping 14 matching lines @@
   EXPECT_TRUE(
       info.LoggingRangeIsFullyReadable(CheckedRange<WinVMAddress, WinVMSize>(
           reinterpret_cast<WinVMAddress>(safe_memory.get()), kAllocationSize)));
   EXPECT_FALSE(info.LoggingRangeIsFullyReadable(
       CheckedRange<WinVMAddress, WinVMSize>(0, 1024)));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad