Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 14220006: Revert 130774 "max-width property is does not overriding the wid..." (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 8 months ago
Reviewers:
commit-queue
CC:
blink-reviews
Visibility:
Public.

Description

Revert 130774 "max-width property is does not overriding the wid..." > max-width property is does not overriding the width properties for css tables(display:table) > https://bugs.webkit.org/show_bug.cgi?id=98455 > > Patch by Pravin D <pravind.2k4@gmail.com>; on 2012-10-09 > Reviewed by Tony Chang. > > Source/WebCore: > > The max-width property determines the maximum computed width an element can have. In case of css tables(display:table), > the computed was not being limited by the max-width property. The current patch fixes this issue. > > Test: fast/table/css-table-max-width.html > > * rendering/RenderTable.cpp: > (WebCore::RenderTable::updateLogicalWidth): > Logic to compute the logical width of an element such that it does not exceed the max-width value. > Also when both min-width and max-width are present, the following contraint is used to compute the logical width: > 1) min-width < Computed LogicalWidth < max-width, when min-width < max-width. > 2) Computed LogicalWidth = min-width, when min-width > max-width. > > LayoutTests: > > * fast/table/css-table-max-width-expected.txt: Added. > * fast/table/css-table-max-width.html: Added. TBR=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -146 lines) Patch
D LayoutTests/fast/table/css-table-max-width.html View 1 chunk +0 lines, -114 lines 0 comments Download
D LayoutTests/fast/table/css-table-max-width-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/WebCore/rendering/RenderTable.cpp View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-19 23:14:38 UTC) #1
Julien - ping for review
7 years, 8 months ago (2013-04-19 23:15:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r148765.

Powered by Google App Engine
This is Rietveld 408576698