Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 14220004: cros: Fix header bar not showing up on lock screen. (Closed)

Created:
7 years, 8 months ago by xiyuan
Modified:
7 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

cros: Fix header bar not showing up on lock screen. login.HeaderBar.animateIn/Out is preferred during refactoring. However, they are not properly wired. This CL fixes the problem. BUG=233722 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
7 years, 8 months ago (2013-04-19 21:54:06 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-19 21:59:45 UTC) #2
Nikita (slow)
thanks!
7 years, 8 months ago (2013-04-19 21:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14220004/1
7 years, 8 months ago (2013-04-19 22:00:29 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 01:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14220004/1
7 years, 8 months ago (2013-04-20 05:07:43 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 05:15:43 UTC) #7
xiyuan
7 years, 8 months ago (2013-04-20 14:25:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r195395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698