chrome/chrome_browser.gypi - Issue 1421983002: Include tab IDs when reporting data use accounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1421983002: Include tab IDs when reporting data use accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_use_scoped_vector

Patch Set: Moved tab ID determination logic into data_usage codebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/data_usage/tab_id_provider_unittest.cc ('K') | « chrome/browser/net/chrome_network_delegate_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/data_usage/core/data_use.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 9f1b8d03142c0d9fb64a376875c14da415fa0ad8..1e4745a82bf3b4e3dcb72c4f47b432d135d6763d 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1471,6 +1471,12 @@

'browser/content_settings/web_site_settings_uma_util.cc',

'browser/content_settings/web_site_settings_uma_util.h',

+ 'chrome_browser_data_usage_sources': [

+ 'browser/data_usage/tab_id_annotator.cc',

+ 'browser/data_usage/tab_id_annotator.h',

+ 'browser/data_usage/tab_id_provider.cc',

+ 'browser/data_usage/tab_id_provider.h',

+ ],

'chrome_browser_engagement_sources': [

'browser/engagement/site_engagement_eviction_policy.cc',

'browser/engagement/site_engagement_eviction_policy.h',

@@ -3278,6 +3284,7 @@

'<@(chrome_browser_bookmark_sources)',

'<@(chrome_browser_browser_process_sources)',

'<@(chrome_browser_content_settings_sources)',

+ '<@(chrome_browser_data_usage_sources)',

'<@(chrome_browser_engagement_sources)',

'<@(chrome_browser_favicon_sources)',

'<@(chrome_browser_google_sources)',