Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/data_usage/core/data_use_aggregator.h

Issue 1421983002: Include tab IDs when reporting data use accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_use_scoped_vector
Patch Set: Polished and added some tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_usage/core/data_use_aggregator.h
diff --git a/components/data_usage/core/data_use_aggregator.h b/components/data_usage/core/data_use_aggregator.h
index 869648dc08940d2d69316c0588bdfbb1f8b58185..f7c34e9a090ddbf69ed8c0d52f431a972f8fac2e 100644
--- a/components/data_usage/core/data_use_aggregator.h
+++ b/components/data_usage/core/data_use_aggregator.h
@@ -15,8 +15,10 @@
#include "base/observer_list.h"
#include "base/threading/thread_checker.h"
-namespace net {
-class URLRequest;
+class GURL;
+
+namespace base {
+class TimeTicks;
}
namespace data_usage {
@@ -42,10 +44,12 @@ class DataUseAggregator {
void RemoveObserver(Observer* observer);
// Virtual for testing.
- virtual void ReportDataUse(const net::URLRequest& request,
- int32_t tab_id,
- int64_t tx_bytes,
- int64_t rx_bytes);
+ virtual void ReportDataUse(int64_t tx_bytes,
+ int64_t rx_bytes,
+ const GURL& url,
+ const base::TimeTicks& request_start,
+ const GURL& first_party_for_cookies,
+ int32_t tab_id);
// Account for off-the-record data use. This usage is only kept track of here
// so that it can be taken out of any amortized data usage calculations, and a

Powered by Google App Engine
This is Rietveld 408576698