Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: net/base/layered_network_delegate_unittest.cc

Issue 1421983002: Include tab IDs when reporting data use accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_use_scoped_vector
Patch Set: Fixed external_data_use_observer test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/layered_network_delegate_unittest.cc
diff --git a/net/base/layered_network_delegate_unittest.cc b/net/base/layered_network_delegate_unittest.cc
index bfdbe7b827b4d056d624a8a3780a2b9ae242c09f..fb427a49c3c07ae0295f7486ddd3d73cc60f2169 100644
--- a/net/base/layered_network_delegate_unittest.cc
+++ b/net/base/layered_network_delegate_unittest.cc
@@ -93,13 +93,12 @@ class TestNetworkDelegateImpl : public NetworkDelegateImpl {
IncrementAndCompareCounter("on_response_started_count");
}
- void OnNetworkBytesReceived(const URLRequest& request,
+ void OnNetworkBytesReceived(URLRequest* request,
int64_t bytes_received) override {
IncrementAndCompareCounter("on_network_bytes_received_count");
}
- void OnNetworkBytesSent(const URLRequest& request,
- int64_t bytes_sent) override {
+ void OnNetworkBytesSent(URLRequest* request, int64_t bytes_sent) override {
IncrementAndCompareCounter("on_network_bytes_sent_count");
}
@@ -202,11 +201,11 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
request_headers.get()));
OnBeforeSendProxyHeaders(NULL, ProxyInfo(), request_headers.get());
OnSendHeaders(NULL, *request_headers);
- OnNetworkBytesSent(*request, 42);
+ OnNetworkBytesSent(request.get(), 42);
EXPECT_EQ(OK, OnHeadersReceived(NULL, completion_callback.callback(),
response_headers.get(), NULL, NULL));
OnResponseStarted(request.get());
- OnNetworkBytesReceived(*request, 42);
+ OnNetworkBytesReceived(request.get(), 42);
OnCompleted(request.get(), false);
OnURLRequestDestroyed(request.get());
OnPACScriptError(0, base::string16());
@@ -284,13 +283,13 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
EXPECT_EQ(1, (*counters_)["on_response_started_count"]);
}
- void OnNetworkBytesReceivedInternal(const URLRequest& request,
+ void OnNetworkBytesReceivedInternal(URLRequest* request,
int64_t bytes_received) override {
++(*counters_)["on_network_bytes_received_count"];
EXPECT_EQ(1, (*counters_)["on_network_bytes_received_count"]);
}
- void OnNetworkBytesSentInternal(const URLRequest& request,
+ void OnNetworkBytesSentInternal(URLRequest* request,
int64_t bytes_sent) override {
++(*counters_)["on_network_bytes_sent_count"];
EXPECT_EQ(1, (*counters_)["on_network_bytes_sent_count"]);
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698