Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2549)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 1421983002: Include tab IDs when reporting data use accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_use_scoped_vector
Patch Set: Fixed external_data_use_observer test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index 0f1971f05278c6f57facdf3236d7e1882ca5a521..852c7552127d33d3618e3407451007b51b448221 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -492,38 +492,21 @@ void ChromeNetworkDelegate::OnResponseStarted(net::URLRequest* request) {
extensions_delegate_->OnResponseStarted(request);
}
-void ChromeNetworkDelegate::OnNetworkBytesReceived(
- const net::URLRequest& request,
- int64_t bytes_received) {
+void ChromeNetworkDelegate::OnNetworkBytesReceived(net::URLRequest* request,
+ int64_t bytes_received) {
#if defined(ENABLE_TASK_MANAGER)
// Note: Currently, OnNetworkBytesReceived is only implemented for HTTP jobs,
// not FTP or other types, so those kinds of bytes will not be reported here.
- task_management::TaskManagerInterface::OnRawBytesRead(request,
+ task_management::TaskManagerInterface::OnRawBytesRead(*request,
bytes_received);
#endif // defined(ENABLE_TASK_MANAGER)
- if (data_use_aggregator_) {
- if (is_data_usage_off_the_record_) {
- data_use_aggregator_->ReportOffTheRecordDataUse(0 /* tx_bytes */,
- bytes_received);
- } else {
- data_use_aggregator_->ReportDataUse(request, -1 /* tab_id */,
- 0 /* tx_bytes */, bytes_received);
- }
- }
+ ReportDataUsageStats(request, 0 /* tx_bytes */, bytes_received);
}
-void ChromeNetworkDelegate::OnNetworkBytesSent(const net::URLRequest& request,
+void ChromeNetworkDelegate::OnNetworkBytesSent(net::URLRequest* request,
int64_t bytes_sent) {
- if (data_use_aggregator_) {
- if (is_data_usage_off_the_record_) {
- data_use_aggregator_->ReportOffTheRecordDataUse(bytes_sent,
- 0 /* rx_bytes */);
- } else {
- data_use_aggregator_->ReportDataUse(request, -1 /* tab_id */, bytes_sent,
- 0 /* rx_bytes */);
- }
- }
+ ReportDataUsageStats(request, bytes_sent, 0 /* rx_bytes */);
}
void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
@@ -742,3 +725,17 @@ bool ChromeNetworkDelegate::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
ReportInvalidReferrerSend(target_url, referrer_url);
return true;
}
+
+void ChromeNetworkDelegate::ReportDataUsageStats(net::URLRequest* request,
+ int64_t tx_bytes,
+ int64_t rx_bytes) {
+ if (!data_use_aggregator_)
+ return;
+
+ if (is_data_usage_off_the_record_) {
+ data_use_aggregator_->ReportOffTheRecordDataUse(tx_bytes, rx_bytes);
+ return;
+ }
+
+ data_use_aggregator_->ReportDataUse(request, tx_bytes, rx_bytes);
+}
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.h ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698