Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: chrome/browser/net/chrome_network_delegate_unittest.cc

Issue 1421983002: Include tab IDs when reporting data use accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_use_scoped_vector
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate_unittest.cc
diff --git a/chrome/browser/net/chrome_network_delegate_unittest.cc b/chrome/browser/net/chrome_network_delegate_unittest.cc
index 5fb4b598b806ee26fa372712e6b048871ff46c2e..9c0ef79a4d5341c0605f8109f9a70b578718e2a6 100644
--- a/chrome/browser/net/chrome_network_delegate_unittest.cc
+++ b/chrome/browser/net/chrome_network_delegate_unittest.cc
@@ -105,10 +105,12 @@ class FakeDataUseAggregator : public data_usage::DataUseAggregator {
off_the_record_rx_bytes_(0) {}
~FakeDataUseAggregator() override {}
- void ReportDataUse(const net::URLRequest& request,
- int32_t tab_id,
- int64_t tx_bytes,
- int64_t rx_bytes) override {
+ void ReportDataUse(int64_t tx_bytes,
tbansal1 2015/10/26 22:24:29 Why not keep the request object? Makes it easier i
sclittle 2015/10/26 23:56:01 You're right, but the request might no longer exis
+ int64_t rx_bytes,
+ const GURL& url,
+ const base::Time& request_time,
+ const GURL& first_party_for_cookies,
+ int32_t tab_id) override {
on_the_record_tx_bytes_ += tx_bytes;
on_the_record_rx_bytes_ += rx_bytes;
}

Powered by Google App Engine
This is Rietveld 408576698