Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1421973007: [swarming] Isolate llvm symbolizer and tsan suppressions file. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
Alexander Potapenko, M-A Ruel, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate llvm symbolizer and tsan suppressions file. BUG=chromium:535160 LOG=n Committed: https://crrev.com/7153c7f48cf50f6179327363e6829796194cf1a0 Cr-Commit-Position: refs/heads/master@{#31696}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M build/isolate.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base.isolate View 1 1 chunk +26 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL. The last bits missing to switch our stand-alone sanitizer bots to swarming. https://codereview.chromium.org/1421973007/diff/20001/src/base.isolate File ...
5 years, 1 month ago (2015-10-30 14:41:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421973007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421973007/20001
5 years, 1 month ago (2015-10-30 14:47:49 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-30 14:48:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421973007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421973007/20001
5 years, 1 month ago (2015-10-30 14:49:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 16:20:57 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:21:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7153c7f48cf50f6179327363e6829796194cf1a0
Cr-Commit-Position: refs/heads/master@{#31696}

Powered by Google App Engine
This is Rietveld 408576698