Follow Material spec for icons when adding web apps to home screen.

Follow Material spec for icons when adding web apps to home screen.

This makes a few visual adjustments to the icons that are added to the
home screen via "Add to home screen":
 - Icons aren't cropped. Previously icons were cropped by 1px, which
   caused circular icons to look broken.
 - We now add padding around the icon in accordance with the Material
   spec for icons [1]. We add padding such that the entire icon width
   with padding is 192 units, while the icon width without padding is
   176 units.
 - To minimize scaling artifacts, icons aren't resized to
   getLauncherLargeIconSize(). getLauncherLargeIconSize() is just a
   guess at the launcher icon size, and is often wrong -- the launcher
   can shows icons at any size it pleases. Instead of resizing the icon
   to the supposed launcher size and then having the launcher resize the
   icon again, we leave the icon at its original size and let the
   launcher do a single rescaling. Unless the icon is much too big; then
   we do scale it down.

[1] The Material spec for icons:
https://www.google.com/design/spec/style/icons.html#icons-product-icons

BUG=530329
Committed: https://crrev.com/a584b9ec2e70e2ea2a56ca9698596ad5e5afea81
Cr-Commit-Position: refs/heads/master@{#356967}

[newt (away), 2015-10-29 18:45:07]

newt@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[newt (away), 2015-10-29 18:45:07]

PTAL

[newt (away), 2015-10-29 18:45:28]

cc mlamouri

[mlamouri (slow - plz ping), 2015-10-29 19:04:50]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-10-29 19:04:51]

sgtm with the rename. I will let Dan do the real review.

https://codereview.chromium.org/1421973005/diff/1/chrome/browser/android/shor...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/1421973005/diff/1/chrome/browser/android/shor...
chrome/browser/android/shortcut_helper.cc:178: result =
Java_ShortcutHelper_generateHomescreenIconFromWebIcon(
nit: please, don't use the term |generate|, we have a boolean |is_generated|
that is false if we go trough that branch.

[newt (away), 2015-10-29 19:42:28]

https://codereview.chromium.org/1421973005/diff/1/chrome/browser/android/shor...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/1421973005/diff/1/chrome/browser/android/shor...
chrome/browser/android/shortcut_helper.cc:178: result =
Java_ShortcutHelper_generateHomescreenIconFromWebIcon(
On 2015/10/29 19:04:51, Mounir Lamouri wrote:
> nit: please, don't use the term |generate|, we have a boolean |is_generated|
> that is false if we go trough that branch.

Good point. Renamed to createHomescreenIconFromWebIcon().

[newt (away), 2015-10-29 19:43:17]

before/after screenshots are on the bug:
https://code.google.com/p/chromium/issues/detail?id=530329#c18

[gone, 2015-10-29 20:51:25]

lgtm

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:260:
public static Bitmap generateHomescreenIconFromWebIcon(Context context, Bitmap
webIcon) {
nit: generateHomeScreenIcon because Android laughed/yelled at us for calling it
a "Homescreen"

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:262: //
wrong -- the launcher can shows icons at any size it pleases. Instead of
resizing the
nit: can show

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:267: int
maxInnerSize = Math.round(am.getLauncherLargeIconSize() * 1.25f);
nit: make a constant

[newt (away), 2015-10-29 21:30:25]

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:260:
public static Bitmap generateHomescreenIconFromWebIcon(Context context, Bitmap
webIcon) {
On 2015/10/29 20:51:25, dfalcantara wrote:
> nit: generateHomeScreenIcon because Android laughed/yelled at us for calling
it
> a "Homescreen"

Replaced most instances of "homescreen" with "home screen", but didn't change
anything though would require changes to other files.

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:262: //
wrong -- the launcher can shows icons at any size it pleases. Instead of
resizing the
On 2015/10/29 20:51:25, dfalcantara wrote:
> nit: can show

Done.

https://codereview.chromium.org/1421973005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:267: int
maxInnerSize = Math.round(am.getLauncherLargeIconSize() * 1.25f);
On 2015/10/29 20:51:25, dfalcantara wrote:
> nit: make a constant

Done.

[newt (away), 2015-10-29 21:30:28]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-10-29 21:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1421973005/#ps40001
(title: "Dan's comments")

[commit-bot: I haz the power, 2015-10-29 21:32:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421973005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421973005/40001

[commit-bot: I haz the power, 2015-10-29 22:29:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-29 22:31:31]

Patchset 3 (id:??) landed as
https://crrev.com/a584b9ec2e70e2ea2a56ca9698596ad5e5afea81
Cr-Commit-Position: refs/heads/master@{#356967}