Move transform property into CSSPropertyParser

Move transform property into CSSPropertyParser

Move transform property handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/52fad32d534a9b31515ddaa53024e469ef32ea07
Cr-Commit-Position: refs/heads/master@{#359618}

[rwlbuis, 2015-11-13 01:13:14]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2015-11-13 07:04:04]

Description was changed from

==========
transform WIP

BUG=
==========

to

==========
Move transform property handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2015-11-13 07:05:41]

Description was changed from

==========
Move transform property handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move transform property into CSSPropertyParser

Move transform property handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2015-11-13 07:07:18]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-11-13 07:07:18]

PTAL.

[Timothy Loh, 2015-11-13 18:11:44]

lgtm

https://codereview.chromium.org/1421963006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1421963006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1643:
RefPtrWillBeRawPtr<CSSPrimitiveValue> parsedValue = consumeLength(args,
cssParserMode, ValueRangeNonNegative);
I guess this could return a CSSPrimitiveValue instead of taking a
CSSFunctionValue and appending to it?

[rwlbuis, 2015-11-13 18:32:28]

On 2015/11/13 18:11:44, Timothy Loh wrote:
> lgtm
> 
>
https://codereview.chromium.org/1421963006/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/1421963006/diff/60001/third_party/WebKit/Sour...
> third_w.party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1643:
> RefPtrWillBeRawPtr<CSSPrimitiveValue> parsedValue = consumeLength(args,
> cssParserMode, ValueRangeNonNegative);
> I guess this could return a CSSPrimitiveValue instead of taking a
> CSSFunctionValue and appending to it?

It could, in fact I had that before and ran into layout test failures :)
My aim here is that I wanted to minimize the number of if (!parsedValue) return
nullptr; usages.
So what works in general case is, if parsedValue is nullptr, simply do not add
it to the list and since we are not at the end of the range we will return
nullptr (consumeTransformValue end-of-function fallback code).
However for consumePerspective this does not work, because consumeNumberRaw will
consume even if perspective is < 0.
And it uses consumeNumberRaw, because that way it is easy to get the double and
combine it with Pixels UnitType.
I am not sure if it is even possible with consumeNumber, but anyway we wanted to
avoid the hacky setUnit type of calls on CSSPrimitiveValue.
So all in all it seems this code will never be perfect, but I did succeed in my
goal of making this way more compact :)
I'll leave you some time to react if you feel strongly about this one but will
likely commit later this afternoon.

[Timothy Loh, 2015-11-13 18:41:39]

On 2015/11/13 18:32:28, rwlbuis wrote:
> However for consumePerspective this does not work, because consumeNumberRaw
will
> consume even if perspective is < 0.
> And it uses consumeNumberRaw, because that way it is easy to get the double
and
> combine it with Pixels UnitType.
> I am not sure if it is even possible with consumeNumber, but anyway we wanted
to
> avoid the hacky setUnit type of calls on CSSPrimitiveValue.

Makes sense, lgtm.

[rwlbuis, 2015-11-13 18:57:54]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-11-13 19:00:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421963006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421963006/60001

[commit-bot: I haz the power, 2015-11-13 20:24:38]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-11-13 20:25:40]

Patchset 3 (id:??) landed as
https://crrev.com/52fad32d534a9b31515ddaa53024e469ef32ea07
Cr-Commit-Position: refs/heads/master@{#359618}