Add missing entry points called by the embedding API's implementation.

Add missing entry points called by the embedding API's implementation.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/0eaf9c164da69bc368c1424a419f58d3f64d8908

[rmacnak, 2015-10-23 23:05:30]

rmacnak@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-10-25 17:20:04]

lgtm

[Florian Schneider, 2015-10-26 10:14:01]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2015-10-26 10:14:01]

https://codereview.chromium.org/1421943002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1421943002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:235: { "dart:typed_data", "_ByteBuffer",
"_ByteBuffer._New" },
Since these are specific to each embedder and may change, wouldn't it make sense
to pass vm_entry_points as a command-line argument in a file to the precompiler?

[rmacnak, 2015-10-26 16:09:35]

https://codereview.chromium.org/1421943002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1421943002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:235: { "dart:typed_data", "_ByteBuffer",
"_ByteBuffer._New" },
On 2015/10/26 10:14:01, Florian Schneider wrote:
> Since these are specific to each embedder and may change, wouldn't it make
sense
> to pass vm_entry_points as a command-line argument in a file to the
precompiler?

There are two lists, one for the VM which is hard-coded here and one for the
embedder which is an argument to Dart_Precompile. The standalone embedder's list
is in bin/main.cc. Chinmay has also added an argument to gen_snapshot to pass
embedder entry points via a file. Because these functions are invoked implicitly
by Dart_New[External]TypedData, I think they belong on the VM list.

[rmacnak, 2015-10-26 16:26:55]

Committed patchset #2 (id:20001) manually as
0eaf9c164da69bc368c1424a419f58d3f64d8908 (presubmit successful).