Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1421933002: Revert of mac: Add auto-close and share-read-only functionality to SharedMemory. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Add auto-close and share-read-only functionality to SharedMemory. (patchset #5 id:80001 of https://codereview.chromium.org/1418113003/ ) Reason for revert: New unit-tests failing on 10.8 http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10139/steps/base_unittests/logs/SharedMemoryMacMultiProcessTest.MachShareToProcessReadonly Original issue's description: > mac: Add auto-close and share-read-only functionality to Mach based SharedMemory. > > base::FileDescriptor has a property |auto_close| that is used to indicate that > when the object is passed to an IPC message, the message takes ownership of the > underlying OS handle. Since SharedMemoryHandle needs to be interchangeable with > base::FileDescriptor, I added a property with similar functionality named > |ownership_passes_to_ipc_|. > > The method ShareToProcess() is used to lower the current and maximum protection > of the underlying OS handle before it is transferred to a different process. I > implemented this functionality for Mach memory objects. > > BUG=535711 > > Committed: https://crrev.com/033bbbcb63cab781552dfb435c035131c423de30 > Cr-Commit-Position: refs/heads/master@{#355880} TBR=mark@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535711 Committed: https://crrev.com/160caaaf74aa406be6acf71b274583d30fa07552 Cr-Commit-Position: refs/heads/master@{#355908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -444 lines) Patch
M base/memory/shared_memory_handle.h View 2 chunks +0 lines, -9 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 6 chunks +2 lines, -22 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 3 chunks +1 line, -69 lines 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 7 chunks +15 lines, -165 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 15 chunks +5 lines, -130 lines 0 comments Download
M ipc/attachment_broker_privileged_mac_unittest.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/test_util_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/test_util_mac.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
erikchen
Created Revert of mac: Add auto-close and share-read-only functionality to SharedMemory.
5 years, 2 months ago (2015-10-23 22:29:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421933002/1
5 years, 2 months ago (2015-10-23 22:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421933002/1
5 years, 2 months ago (2015-10-23 22:32:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 22:34:08 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 22:35:00 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/160caaaf74aa406be6acf71b274583d30fa07552
Cr-Commit-Position: refs/heads/master@{#355908}

Powered by Google App Engine
This is Rietveld 408576698