Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 142193006: Remove unnecessary include of ATL headers (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org, Peng
Visibility:
Public.

Description

Remove unnecessary include of ATL headers R=nona@chromium.org BUG=5027 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/base/ime/win/imm32_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
scottmg
6 years, 10 months ago (2014-01-30 01:15:36 UTC) #1
scottmg
6 years, 10 months ago (2014-01-31 21:55:03 UTC) #2
Seigo Nonaka
lgtm
6 years, 10 months ago (2014-02-03 17:01:10 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-03 17:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/142193006/1
6 years, 10 months ago (2014-02-03 17:22:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 19:58:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255648
6 years, 10 months ago (2014-02-03 19:58:12 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:58:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:58:19 UTC) #9
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-03 20:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/142193006/1
6 years, 10 months ago (2014-02-03 20:01:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 23:10:55 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255780
6 years, 10 months ago (2014-02-03 23:10:55 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:10:57 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:10:59 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:10:59 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:11:02 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:11:03 UTC) #18
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-03 23:12:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/142193006/1
6 years, 10 months ago (2014-02-03 23:19:53 UTC) #20
commit-bot: I haz the power
Change committed as 248632
6 years, 10 months ago (2014-02-04 00:37:16 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:37:17 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:37:20 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:37:21 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:37:23 UTC) #25
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:37:23 UTC) #26
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698