sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart - Issue 142193005: Fix JS-backend when MirrorsUsed target a static field, but there is no mirrors usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 142193005: Fix JS-backend when MirrorsUsed target a static field, but there is no mirrors usage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Extract function that finds static field targets. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/compiler/dart2js/mirror_tree_shaking_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

index 5667204f2d54b8c513b6264e6052d990ee3b7e0c..763222029f822cd94fff6725fcfcda789b4bc4b2 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

@@ -97,14 +97,9 @@ class ClassEmitter extends CodeEmitterHelper {

bool emitStatics: false,

bool onlyForRti: false }) {

assert(!emitStatics || !onlyForRti);

- bool isClass = false;

- bool isLibrary = false;

- if (element.isClass()) {

- isClass = true;

- } else if (element.isLibrary()) {

- isLibrary = false;

+ if (element.isLibrary()) {

assert(invariant(element, emitStatics));

- } else {

+ } else if (!element.isClass()) {

throw new SpannableAssertionFailure(

element, 'Must be a ClassElement or a LibraryElement');

}