Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1421903008: Revert of SSL in EmbeddedTestServer (Closed)

Created:
5 years, 1 month ago by stevenjb
Modified:
5 years, 1 month ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SSL in EmbeddedTestServer (patchset #55 id:1070001 of https://codereview.chromium.org/1376593007/ ) Reason for revert: This breaks cros_trunk, failure started here: http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/40350 crbug.com/548358 Original issue's description: > SSL and add handlers in EmbeddedTestServer > > As part of the migration of tests to EmbeddedTestServer, this CL modifies > EmbeddedTestServer to support SSLServerSocket and to add shared default handlers > that can be used by tests to mirror the SpawnedTestServer handlers. The major > changes are: > > - SSL support through SSLServerSocket > - Adding SSLServerConfig to configure SSLServerSockets. > - Setting up default handlers for BrowserTestBase tests. > - Asynchronous HttpResponse. > - Moving EmbeddedTestServer to the net:: namespace. > > BUG=496825 > NOPRESUBMIT=TRUE > > Committed: https://crrev.com/5c265faa70626b7754e8b62300f65771dae2adbf > Cr-Commit-Position: refs/heads/master@{#356305} TBR=davidben@chromium.org,kelvinp@chromium.org,lazyboy@chromium.org,mmenke@chromium.org,asanka@chromium.org,sergeyu@chromium.org,svaldez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496825 Committed: https://crrev.com/d50b4910a3c5b388f74fb50bc98587cb59e4e295 Cr-Commit-Position: refs/heads/master@{#356411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -1024 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 3 chunks +24 lines, -4 lines 0 comments Download
M content/public/test/browser_test_base.h View 4 chunks +10 lines, -14 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/content_browser_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/ssl_server_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_server_socket_nss.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D net/ssl/ssl_server_config.h View 1 chunk +0 lines, -63 lines 0 comments Download
D net/ssl/ssl_server_config.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.h View 9 chunks +15 lines, -91 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 8 chunks +77 lines, -159 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 18 chunks +45 lines, -228 lines 0 comments Download
M net/test/embedded_test_server/http_connection.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/test/embedded_test_server/http_connection.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M net/test/embedded_test_server/http_request.h View 3 chunks +0 lines, -6 lines 0 comments Download
M net/test/embedded_test_server/http_request.cc View 5 chunks +5 lines, -24 lines 0 comments Download
M net/test/embedded_test_server/http_response.h View 4 chunks +7 lines, -38 lines 0 comments Download
M net/test/embedded_test_server/http_response.cc View 3 chunks +4 lines, -28 lines 0 comments Download
D net/test/embedded_test_server/request_handler_util.h View 1 chunk +0 lines, -63 lines 0 comments Download
D net/test/embedded_test_server/request_handler_util.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
Created Revert of SSL in EmbeddedTestServer
5 years, 1 month ago (2015-10-27 22:20:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421903008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421903008/1
5 years, 1 month ago (2015-10-27 22:20:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 22:23:20 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 22:24:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d50b4910a3c5b388f74fb50bc98587cb59e4e295
Cr-Commit-Position: refs/heads/master@{#356411}

Powered by Google App Engine
This is Rietveld 408576698