Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/components_tests.gyp

Issue 1421893002: Revert of Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/chromecast.gyp ('k') | components/html_viewer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components_tests.gyp
diff --git a/components/components_tests.gyp b/components/components_tests.gyp
index 6d0bbd38f0128214283956ea512e605377d493fb..de0efea9205baca91cdb4c87dbd1bd0a6f8107c4 100644
--- a/components/components_tests.gyp
+++ b/components/components_tests.gyp
@@ -1449,6 +1449,12 @@
'<(PRODUCT_DIR)/icudtl.dat',
],
}],
+ ['v8_use_external_startup_data==1', {
+ 'components_browsertests_pak_input_resources': [
+ '<(PRODUCT_DIR)/natives_blob.bin',
+ '<(PRODUCT_DIR)/snapshot_blob.bin',
+ ],
+ }],
],
},
'targets': [
@@ -1458,28 +1464,13 @@
'dependencies': [
'components_browsertests',
],
- 'variables': {
- 'dest_path': '<(PRODUCT_DIR)/components_browsertests_apk_shell/assets',
- 'src_files': [
- '<@(components_browsertests_pak_input_resources)',
- ],
- 'clear': 1,
- 'conditions': [
- ['v8_use_external_startup_data==1', {
- 'renaming_sources': [
- '<(PRODUCT_DIR)/natives_blob.bin',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- 'renaming_destinations': [
- 'natives_blob_<(arch_suffix).bin',
- 'snapshot_blob_<(arch_suffix).bin',
- ],
- }],
- ],
- },
- 'includes': [
- '../build/android/copy_ex.gypi',
- '../build/android/v8_external_startup_data_arch_suffix.gypi',
+ 'copies': [
+ {
+ 'destination': '<(PRODUCT_DIR)/components_browsertests_apk_shell/assets',
+ 'files': [
+ '<@(components_browsertests_pak_input_resources)',
+ ],
+ }
],
},
{
« no previous file with comments | « chromecast/chromecast.gyp ('k') | components/html_viewer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698