Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: third_party/WebKit/Source/web/web_tests.gyp

Issue 1421893002: Revert of Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform_tests.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/web_tests.gyp
diff --git a/third_party/WebKit/Source/web/web_tests.gyp b/third_party/WebKit/Source/web/web_tests.gyp
index 9a2948031818178693aa62484605e4c13487dbca..b4277c8a1cf5a3de2dd893a2061efe5657811da9 100644
--- a/third_party/WebKit/Source/web/web_tests.gyp
+++ b/third_party/WebKit/Source/web/web_tests.gyp
@@ -141,9 +141,17 @@
'type': 'none',
'dependencies': [
'<(DEPTH)/base/base.gyp:base_java',
- '<(DEPTH)/content/content.gyp:content_shell_assets_copy',
+ '<(DEPTH)/content/content_shell_and_tests.gyp:content_shell_pak',
'<(DEPTH)/net/net.gyp:net_java',
'webkit_unit_tests',
+ ],
+ 'conditions': [
+ ['v8_use_external_startup_data==1', {
+ 'dependencies': [
+ '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_external_snapshot',
+ '<(DEPTH)/content/content.gyp:content_v8_external_data',
+ ],
+ }],
],
'variables': {
'test_suite_name': 'webkit_unit_tests',
@@ -153,16 +161,13 @@
'conditions': [
['v8_use_external_startup_data==1', {
'additional_input_paths': [
- '<(PRODUCT_DIR)/content_shell/assets/natives_blob_<(arch_suffix).bin',
- '<(PRODUCT_DIR)/content_shell/assets/snapshot_blob_<(arch_suffix).bin',
+ '<(PRODUCT_DIR)/content_shell/assets/natives_blob.bin',
+ '<(PRODUCT_DIR)/content_shell/assets/snapshot_blob.bin',
],
}],
],
},
- 'includes': [
- '../../../../build/apk_test.gypi',
- '../../../../build/android/v8_external_startup_data_arch_suffix.gypi',
- ],
+ 'includes': [ '../../../../build/apk_test.gypi' ],
}],
}],
['test_isolation_mode != "noop"', {
« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform_tests.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698