gin/v8_initializer.cc - Issue 1421893002: Revert of Reland Switch Chrome Android using v8 arch specific external data name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/v8_initializer.cc

Issue 1421893002: Revert of Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/v8_initializer.cc

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc

index 8bcc78dfa772568d61de2a46bb56e0eaaee95a9d..810225c9c8664bccf461c8af75933e24b2539f1f 100644

--- a/gin/v8_initializer.cc

+++ b/gin/v8_initializer.cc

@@ -53,19 +53,8 @@

base::MemoryMappedFile::Region g_natives_region;

base::MemoryMappedFile::Region g_snapshot_region;

-#if defined(OS_ANDROID)

-#ifdef __LP64__

-const char kNativesFileName[] = "natives_blob_64.bin";

-const char kSnapshotFileName[] = "snapshot_blob_64.bin";

-#else

-const char kNativesFileName[] = "natives_blob_32.bin";

-const char kSnapshotFileName[] = "snapshot_blob_32.bin";

-#endif // __LP64__

-#else // defined(OS_ANDROID)

const char kNativesFileName[] = "natives_blob.bin";

const char kSnapshotFileName[] = "snapshot_blob.bin";

-#endif // defined(OS_ANDROID)

void GetV8FilePath(const char* file_name, base::FilePath* path_out) {

#if !defined(OS_MACOSX)

« no previous file with comments | « content/shell/android/BUILD.gn ('k') | net/net.gyp » ('j') | no next file with comments »