Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1421883002: Even block flows with inline children must be examined when balancing columns. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Even block flows with inline children must be examined when balancing columns. Even if a block flow is marked as having only inline children, it may still contain interesting floats that need to be paginated. BUG=547024 R=leviw@chromium.org Committed: https://crrev.com/ecc4cc8996d447a02a0d43a2537ae4f065b3f6c2 Cr-Commit-Position: refs/heads/master@{#356262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/balance-floats.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/balance-floats-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-23 20:24:57 UTC) #1
leviw_travelin_and_unemployed
lgtm Ahh sure. Formatting contexts ftw.
5 years, 1 month ago (2015-10-26 22:39:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421883002/1
5 years, 1 month ago (2015-10-26 22:41:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/125942)
5 years, 1 month ago (2015-10-27 00:46:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421883002/1
5 years, 1 month ago (2015-10-27 08:49:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 10:13:41 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 10:14:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecc4cc8996d447a02a0d43a2537ae4f065b3f6c2
Cr-Commit-Position: refs/heads/master@{#356262}

Powered by Google App Engine
This is Rietveld 408576698