Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421873007: Change QuicWallTime to have microsecond granularity. (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106444524
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicWallTime to have microsecond granularity. Merge internal change: 106446616 R=rtennet@chromium.org BUG=

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M net/quic/quic_clock.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_time.h View 2 chunks +15 lines, -9 lines 2 comments Download
M net/quic/quic_time.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M net/tools/quic/quic_epoll_clock.h View 1 chunk +4 lines, -0 lines 2 comments Download
M net/tools/quic/quic_epoll_clock.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_clock_test.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1420623004 Patch 1

Dependent Patchsets:

Issue 1410013010 Patch 1

Messages

Total messages: 5 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 20:56:34 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/1421873007/diff/1/net/quic/quic_time.h File net/quic/quic_time.h (right): https://codereview.chromium.org/1421873007/diff/1/net/quic/quic_time.h#newcode164 net/quic/quic_time.h:164: // requires some flex overly nit: period at ...
5 years, 1 month ago (2015-11-03 00:33:10 UTC) #4
Ryan Hamilton
5 years, 1 month ago (2015-11-04 04:10:11 UTC) #5 
Done in the final CL. Thanks!

https://codereview.chromium.org/1421873007/diff/1/net/quic/quic_time.h
File net/quic/quic_time.h (right):

https://codereview.chromium.org/1421873007/diff/1/net/quic/quic_time.h#newcod...
net/quic/quic_time.h:164: // requires some flex
On 2015/11/03 00:33:10, ramant wrote:
> overly nit: period at the end of sentence.

Done.

https://codereview.chromium.org/1421873007/diff/1/net/tools/quic/quic_epoll_c...
File net/tools/quic/quic_epoll_clock.h (right):

https://codereview.chromium.org/1421873007/diff/1/net/tools/quic/quic_epoll_c...
net/tools/quic/quic_epoll_clock.h:34: // Note: this use significant resources
please use only if needed.
On 2015/11/03 00:33:10, ramant wrote:
> overly nit: "this use" -> "this uses"?

Done.

Powered by Google App Engine
This is Rietveld 408576698