Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421863004: Fix compile error mac 10.8. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix compile error mac 10.8. The mac 10.8 compiler seems to get the constructor wrong. Remove the SkNoCopy. BUG=skia:4037 Committed: https://skia.googlesource.com/skia/+/a267904213ee6220982918b4c4358988e3230dc5

Patch Set 1 #

Patch Set 2 : try 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkDraw.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421863004/20001
5 years, 1 month ago (2015-11-09 18:31:56 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-09 18:31:56 UTC) #3
herb_g
5 years, 1 month ago (2015-11-09 18:32:55 UTC) #6
mtklein
lgtm
5 years, 1 month ago (2015-11-09 18:48:06 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 18:49:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a267904213ee6220982918b4c4358988e3230dc5

Powered by Google App Engine
This is Rietveld 408576698