Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 1421823002: Move performance dashboard upload logic to devtoolslib. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move performance dashboard upload logic to devtoolslib. This patch moves the logic that uploads chart_data to performance dashboard, as well as the command line args spec that configures such upload to devtoolslib, so that it can be shared between `mojo_benchmark` and `perf_test_runner` (in a follow-up). R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/aa9b52c175231c8677ac279a0630fda1b121ce50

Patch Set 1 #

Patch Set 2 : Move the argparse part too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -140 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 1 2 chunks +126 lines, -1 line 0 comments Download
M mojo/tools/get_test_list.py View 2 chunks +5 lines, -2 lines 0 comments Download
D mojo/tools/mopy/perf_data_uploader.py View 1 chunk +0 lines, -103 lines 0 comments Download
M mojo/tools/perf_test_runner.py View 1 3 chunks +17 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 2 months ago (2015-10-23 11:53:31 UTC) #2
ppi
Moved argparse config too in patch set 2, ptal.
5 years, 2 months ago (2015-10-23 13:14:48 UTC) #3
etiennej
lgtm
5 years, 2 months ago (2015-10-23 15:05:15 UTC) #4
ppi
5 years, 2 months ago (2015-10-23 15:11:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aa9b52c175231c8677ac279a0630fda1b121ce50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698