Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1421803002: X87: [runtime] Implement %_ToLength via ToLengthStub. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Implement %_ToLength via ToLengthStub. port e678a0f9a961165ab43cd1a6080fcb11995b701a (r31358) original commit message: Use %_ToLength for TO_LENGTH, implemented via a ToLengthStub that supports a fast path for small integers. Everything else is still handled in the runtime. BUG= Committed: https://crrev.com/9f4ff3b1cd2008c90383776a64efa3de63908d95 Cr-Commit-Position: refs/heads/master@{#31542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 14:58:38 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-10-26 03:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421803002/1
5 years, 1 month ago (2015-10-26 03:27:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 03:50:32 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 03:51:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f4ff3b1cd2008c90383776a64efa3de63908d95
Cr-Commit-Position: refs/heads/master@{#31542}

Powered by Google App Engine
This is Rietveld 408576698