Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 14218002: Move WidgetHierarchyUpdatesSuspensionScope into removeChildren loop (Closed)

Created:
7 years, 8 months ago by esprehn
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

NOTE: This is Obsolete. We need to find a better way to write that whole loop. I rolled out my original patch until then. Move WidgetHierarchyUpdatesSuspensionScope into removeChildren loop r148127 seems to be causing tons of crashes on myspace.com and others when doing Widget heirachy updates. It's not clear why this happens since you need to use the back button to cause it, but moving the WidgetHierarchyUpdatesSuspensionScope into the loop fixes it. This makes sense since we shouldn't let script run while the Widget tree is in an invalid state. I don't know how to write a LayoutTest for this change. R=eseidel@chromium.org CC=karen@chromium.org,jamesr@chromium.org BUG=230592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M Source/WebCore/dom/ContainerNode.cpp View 1 chunk +25 lines, -26 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
esprehn
7 years, 8 months ago (2013-04-12 03:23:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698