Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 1421733002: Introduce IOSChromeMetricsServicesManagerClient (Closed)

Created:
5 years, 2 months ago by blundell
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce IOSChromeMetricsServicesManagerClient This CL introduces the //ios/chrome analogue to //chrome's ChromeMetricsServicesManagerClient. BUG=545991 Committed: https://crrev.com/498aca68b275fb880d9b32e7109c63bd2968fcaa Cr-Commit-Position: refs/heads/master@{#356015}

Patch Set 1 #

Patch Set 2 : git add client #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -13 lines) Patch
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.h View 1 chunk +2 lines, -1 line 0 comments Download
A + ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h View 1 3 chunks +9 lines, -12 lines 0 comments Download
A ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.cc View 1 1 chunk +101 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
blundell
5 years, 2 months ago (2015-10-22 11:40:58 UTC) #2
droger
LGTM would it make sense to move the switch to a component and share it?
5 years, 2 months ago (2015-10-23 16:55:29 UTC) #3
blundell
On 2015/10/23 16:55:29, droger wrote: > LGTM > > would it make sense to move ...
5 years, 1 month ago (2015-10-26 06:57:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421733002/20001
5 years, 1 month ago (2015-10-26 06:58:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 07:08:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 07:09:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/498aca68b275fb880d9b32e7109c63bd2968fcaa
Cr-Commit-Position: refs/heads/master@{#356015}

Powered by Google App Engine
This is Rietveld 408576698