platform_tools/android/bin/gyp_to_android.py - Issue 142173002: Add self tests for gyp_to_android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/bin/gyp_to_android.py

Issue 142173002: Add self tests for gyp_to_android. (Closed) Base URL: https://skia.googlesource.com/skia.git@GYP2

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/bin/gyp_to_android.py

diff --git a/platform_tools/android/bin/gyp_to_android.py b/platform_tools/android/bin/gyp_to_android.py

index 9d887c4c2d5320a0c675f7eb1a4c189d33ee5214..1e789e912bb83303d121a4fb0af962a1e8ec3262 100644

--- a/platform_tools/android/bin/gyp_to_android.py

+++ b/platform_tools/android/bin/gyp_to_android.py

@@ -413,6 +413,7 @@ def main():

WriteAndroidMk(common, arm_var_dict, arm_neon_var_dict, x86_var_dict,

default_var_dict)

+ return 0

epoger 2014/01/21 20:00:51 How would main() ever return anything but 0?

scroggo 2014/01/22 16:36:48 It would not. Removed.

scroggo 2014/01/22 19:32:50 D'oh! I thought I removed it. Removed in next patc

if __name__ == '__main__':

main()

« no previous file with comments | « no previous file | tools/tests/gyp_to_android_tests.py » ('j') | tools/tests/gyp_to_android_tests.py » ('J')