Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421723004: Add visualbench option for device-independent fonts (Closed)

Created:
5 years, 2 months ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add visualbench option for device-independent fonts BUG=skia: Committed: https://skia.googlesource.com/skia/+/c70483f5ab83aaa29c0697398aeca3432f3591b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M tools/VisualBench/VisualBench.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/WrappedBenchmark.h View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Chris Dalton
This gets the job done, but I'm open to any suggestions.
5 years, 2 months ago (2015-10-24 00:05:17 UTC) #2
Chris Dalton
5 years, 1 month ago (2015-10-26 19:25:16 UTC) #4
joshualitt
On 2015/10/26 19:25:16, Chris Dalton wrote: lgtm
5 years, 1 month ago (2015-10-26 19:40:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421723004/1
5 years, 1 month ago (2015-10-26 20:03:37 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 20:14:39 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c70483f5ab83aaa29c0697398aeca3432f3591b6

Powered by Google App Engine
This is Rietveld 408576698