Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/views/widget/drop_helper.cc

Issue 1421713002: Explicitly convert Point to PointF for event code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip
Patch Set: pointfconvert-prod: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc ('k') | ui/views/widget/root_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/drop_helper.cc
diff --git a/ui/views/widget/drop_helper.cc b/ui/views/widget/drop_helper.cc
index bc9f394777a7b729a6976e65f297b3945588b9ce..61d8e3f7b79cc2b1fbd8458e52c1d4b1bebff2ad 100644
--- a/ui/views/widget/drop_helper.cc
+++ b/ui/views/widget/drop_helper.cc
@@ -63,8 +63,8 @@ int DropHelper::OnDrop(const OSExchangeData& data,
gfx::Point view_location(root_view_location);
View* root_view = drop_view->GetWidget()->GetRootView();
View::ConvertPointToTarget(root_view, drop_view, &view_location);
- ui::DropTargetEvent drop_event(data, view_location, view_location,
- drag_operation);
+ ui::DropTargetEvent drop_event(data, gfx::PointF(view_location),
+ gfx::PointF(view_location), drag_operation);
return drop_view->OnPerformDrop(drop_event);
}
@@ -126,9 +126,8 @@ void DropHelper::NotifyDragEntered(const OSExchangeData& data,
gfx::Point target_view_location(root_view_location);
View::ConvertPointToTarget(root_view_, target_view_, &target_view_location);
- ui::DropTargetEvent enter_event(data,
- target_view_location,
- target_view_location,
+ ui::DropTargetEvent enter_event(data, gfx::PointF(target_view_location),
+ gfx::PointF(target_view_location),
drag_operation);
target_view_->OnDragEntered(enter_event);
}
@@ -141,9 +140,8 @@ int DropHelper::NotifyDragOver(const OSExchangeData& data,
gfx::Point target_view_location(root_view_location);
View::ConvertPointToTarget(root_view_, target_view_, &target_view_location);
- ui::DropTargetEvent enter_event(data,
- target_view_location,
- target_view_location,
+ ui::DropTargetEvent enter_event(data, gfx::PointF(target_view_location),
+ gfx::PointF(target_view_location),
drag_operation);
return target_view_->OnDragUpdated(enter_event);
}
« no previous file with comments | « ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc ('k') | ui/views/widget/root_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698