ui/views/accessibility/native_view_accessibility.cc - Issue 1421713002: Explicitly convert Point to PointF for event code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility.cc

Issue 1421713002: Explicitly convert Point to PointF for event code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip

Patch Set: pointfconvert-prod: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/accessibility/native_view_accessibility.cc

diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc

index db8367fcefb1554900df50451b58c166d58bd943..7b2b1cf76bcec57fa82659cf80102193f50abff0 100644

--- a/ui/views/accessibility/native_view_accessibility.cc

+++ b/ui/views/accessibility/native_view_accessibility.cc

@@ -177,18 +177,14 @@ NativeViewAccessibility::GetTargetForNativeAccessibilityEvent() {

void NativeViewAccessibility::DoDefaultAction() {

gfx::Point center = view_->GetLocalBounds().CenterPoint();

- view_->OnMousePressed(ui::MouseEvent(ui::ET_MOUSE_PRESSED,

- center,

- ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON,

- ui::EF_LEFT_MOUSE_BUTTON));

- view_->OnMouseReleased(ui::MouseEvent(ui::ET_MOUSE_RELEASED,

- center,

- ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON,

- ui::EF_LEFT_MOUSE_BUTTON));

+ view_->OnMousePressed(

+ ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::PointF(center),

+ gfx::PointF(center), ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));

+ view_->OnMouseReleased(

+ ui::MouseEvent(ui::ET_MOUSE_RELEASED, gfx::PointF(center),

+ gfx::PointF(center), ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));

}

bool NativeViewAccessibility::SetStringValue(const base::string16& new_value) {