Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421703004: Initialize maths result array in JS. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Initialize maths result array in JS. R=ishell@chromium.org Committed: https://crrev.com/aa26f5d4a11a1e5655d425ff40ced79c8ecdd55f Cr-Commit-Position: refs/heads/master@{#31722} Committed: https://crrev.com/210c18cf11da5ade25fc44c881975942851b62df Cr-Commit-Position: refs/heads/master@{#31735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M src/bootstrapper.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M src/js/prologue.js View 4 chunks +4 lines, -6 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Yang
5 years, 1 month ago (2015-11-02 14:32:15 UTC) #1
Igor Sheludko
lgtm
5 years, 1 month ago (2015-11-02 18:13:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421703004/1
5 years, 1 month ago (2015-11-02 20:51:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 21:23:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa26f5d4a11a1e5655d425ff40ced79c8ecdd55f Cr-Commit-Position: refs/heads/master@{#31722}
5 years, 1 month ago (2015-11-02 21:23:35 UTC) #6
Michael Lippautz
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1409143011/ by mlippautz@chromium.org. ...
5 years, 1 month ago (2015-11-02 23:33:32 UTC) #7
Yang
On 2015/11/02 23:33:32, Michael Lippautz wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 1 month ago (2015-11-03 08:22:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421703004/1
5 years, 1 month ago (2015-11-03 08:22:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 08:24:31 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 08:24:46 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/210c18cf11da5ade25fc44c881975942851b62df
Cr-Commit-Position: refs/heads/master@{#31735}

Powered by Google App Engine
This is Rietveld 408576698