Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: media/base/mock_filters.h

Issue 14217008: Remove reference counting from media::DemuxerStream and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mock_filters.h
diff --git a/media/base/mock_filters.h b/media/base/mock_filters.h
index bd4fd9cb04cba840237de2be13ef9fc9dcc2ddae..5dd4c98f0933284a1d29f0e51da881e09be0ec0e 100644
--- a/media/base/mock_filters.h
+++ b/media/base/mock_filters.h
@@ -35,7 +35,7 @@ class MockDemuxer : public Demuxer {
MOCK_METHOD2(Seek, void(base::TimeDelta time, const PipelineStatusCB& cb));
MOCK_METHOD1(Stop, void(const base::Closure& callback));
MOCK_METHOD0(OnAudioRendererDisabled, void());
- MOCK_METHOD1(GetStream, scoped_refptr<DemuxerStream>(DemuxerStream::Type));
+ MOCK_METHOD1(GetStream, DemuxerStream*(DemuxerStream::Type));
MOCK_CONST_METHOD0(GetStartTime, base::TimeDelta());
private:
@@ -45,6 +45,7 @@ class MockDemuxer : public Demuxer {
class MockDemuxerStream : public DemuxerStream {
public:
MockDemuxerStream();
+ virtual ~MockDemuxerStream();
// DemuxerStream implementation.
MOCK_METHOD0(type, Type());
@@ -53,9 +54,6 @@ class MockDemuxerStream : public DemuxerStream {
MOCK_METHOD0(video_decoder_config, const VideoDecoderConfig&());
MOCK_METHOD0(EnableBitstreamConverter, void());
- protected:
- virtual ~MockDemuxerStream();
-
private:
DISALLOW_COPY_AND_ASSIGN(MockDemuxerStream);
};
@@ -63,9 +61,10 @@ class MockDemuxerStream : public DemuxerStream {
class MockVideoDecoder : public VideoDecoder {
public:
MockVideoDecoder();
+ virtual ~MockVideoDecoder();
// VideoDecoder implementation.
- MOCK_METHOD3(Initialize, void(const scoped_refptr<DemuxerStream>&,
+ MOCK_METHOD3(Initialize, void(DemuxerStream*,
const PipelineStatusCB&,
const StatisticsCB&));
MOCK_METHOD1(Read, void(const ReadCB&));
@@ -73,9 +72,6 @@ class MockVideoDecoder : public VideoDecoder {
MOCK_METHOD1(Stop, void(const base::Closure&));
MOCK_CONST_METHOD0(HasAlpha, bool());
- protected:
- virtual ~MockVideoDecoder();
-
private:
DISALLOW_COPY_AND_ASSIGN(MockVideoDecoder);
};
@@ -83,9 +79,10 @@ class MockVideoDecoder : public VideoDecoder {
class MockAudioDecoder : public AudioDecoder {
public:
MockAudioDecoder();
+ virtual ~MockAudioDecoder();
// AudioDecoder implementation.
- MOCK_METHOD3(Initialize, void(const scoped_refptr<DemuxerStream>&,
+ MOCK_METHOD3(Initialize, void(DemuxerStream*,
const PipelineStatusCB&,
const StatisticsCB&));
MOCK_METHOD1(Read, void(const ReadCB&));
@@ -94,9 +91,6 @@ class MockAudioDecoder : public AudioDecoder {
MOCK_METHOD0(samples_per_second, int(void));
MOCK_METHOD1(Reset, void(const base::Closure&));
- protected:
- virtual ~MockAudioDecoder();
-
private:
DISALLOW_COPY_AND_ASSIGN(MockAudioDecoder);
};
@@ -107,7 +101,7 @@ class MockVideoRenderer : public VideoRenderer {
virtual ~MockVideoRenderer();
// VideoRenderer implementation.
- MOCK_METHOD9(Initialize, void(const scoped_refptr<DemuxerStream>& stream,
+ MOCK_METHOD9(Initialize, void(DemuxerStream* stream,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const TimeCB& time_cb,
@@ -133,7 +127,7 @@ class MockAudioRenderer : public AudioRenderer {
virtual ~MockAudioRenderer();
// AudioRenderer implementation.
- MOCK_METHOD8(Initialize, void(const scoped_refptr<DemuxerStream>& stream,
+ MOCK_METHOD8(Initialize, void(DemuxerStream* stream,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const base::Closure& underflow_cb,

Powered by Google App Engine
This is Rietveld 408576698