Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421673002: media: Fix gn build for AVDA related files on Android. (Closed)

Created:
5 years, 2 months ago by xhwang
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn build for AVDA related files on Android. BUG=507834 TEST=Compiles with "media_use_ffmpeg = true". Committed: https://crrev.com/f3510926e755ff862910aa54dcf71921a1380f78 Cr-Commit-Position: refs/heads/master@{#355412}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/common/BUILD.gn View 1 chunk +6 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
xhwang
PTAL
5 years, 2 months ago (2015-10-21 21:17:15 UTC) #2
liberato (no reviews please)
lgtm % maybe missing one file. https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn#newcode339 content/common/BUILD.gn:339: sources += [ ...
5 years, 2 months ago (2015-10-21 21:20:20 UTC) #3
xhwang
https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn#newcode339 content/common/BUILD.gn:339: sources += [ On 2015/10/21 21:20:19, liberato wrote: > ...
5 years, 2 months ago (2015-10-21 21:23:09 UTC) #4
liberato (no reviews please)
https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://chromiumcodereview.appspot.com/1421673002/diff/1/content/common/BUILD.gn#newcode339 content/common/BUILD.gn:339: sources += [ On 2015/10/21 21:23:09, xhwang wrote: > ...
5 years, 2 months ago (2015-10-21 21:24:42 UTC) #5
xhwang
nasko@chromium.org: Please OWNERS review this trivial gn change!
5 years, 2 months ago (2015-10-21 21:26:05 UTC) #7
nasko
Rubberstamp LGTM
5 years, 2 months ago (2015-10-21 21:32:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421673002/1
5 years, 2 months ago (2015-10-21 21:37:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 22:29:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 22:39:03 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f3510926e755ff862910aa54dcf71921a1380f78
Cr-Commit-Position: refs/heads/master@{#355412}

Powered by Google App Engine
This is Rietveld 408576698