Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1421613003:
Android: add documentation about junit tests. (Closed)
|
Created:
5 years, 2 months ago by mlamouri (slow - plz ping) Modified:
5 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAndroid: add documentation about junit tests.
There is no clear documentation explaining how to build and run junit
tests. Hopefully this will help.
BUG=None
Committed: https://crrev.com/0fbd6cd844d535f80c8c4abaaad5ebe6f496dcc7
Cr-Commit-Position: refs/heads/master@{#356033}
Patch Set 1 #
Total comments: 12
Patch Set 2 : review comments #
Total comments: 5
Patch Set 3 : review comments #Messages
Total messages: 15 (3 generated)
mlamouri@chromium.org changed reviewers: + dgn@chromium.org
bauerb@chromium.org changed reviewers: + bauerb@chromium.org
Drive-by review! https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:154: ## Junit tests Nit: JUnit (capital U) here and elsewhere. https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:161: ```chrome_junit_tests```. There are more JUnit test suites than that, e.g. base_junit_tests, components_junit_tests, net_junit_tests, ...
https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:127: pointing to "out_android". You can also use ```--output-directory``` to point I think triple backtick make a new paragraph. Did you check how the file is rendered on gitiles? https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:161: ```chrome_junit_tests```. On 2015/10/22 16:19:12, Bernhard Bauer wrote: > There are more JUnit test suites than that, e.g. base_junit_tests, > components_junit_tests, net_junit_tests, ... I wish there was a unified junit target with all the tests... It's not like it's going to take as long as the instrumentation tests to build and run https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:177: entire package name has to be used. Not true. This is working for me: net_junit_tests -f "*testGetNextAuthToken"
Comments applied. PTAL. bauerb@, given that dgn@ is OOO today, do you mind taking care of the full review? :) https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:127: pointing to "out_android". You can also use ```--output-directory``` to point On 2015/10/22 at 18:09:23, dgn wrote: > I think triple backtick make a new paragraph. No. > Did you check how the file is rendered on gitiles? I did try on gitiles in case of it was a gitiles oddities. I'm glad it's not :) https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:154: ## Junit tests On 2015/10/22 at 16:19:12, Bernhard Bauer wrote: > Nit: JUnit (capital U) here and elsewhere. Done. https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:161: ```chrome_junit_tests```. On 2015/10/22 at 18:09:23, dgn wrote: > On 2015/10/22 16:19:12, Bernhard Bauer wrote: > > There are more JUnit test suites than that, e.g. base_junit_tests, > > components_junit_tests, net_junit_tests, ... > > I wish there was a unified junit target with all the tests... It's not like it's going to take as long as the instrumentation tests to build and run Changed to mention content_junit_tests and chrome_junit_tests as examples. https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:177: entire package name has to be used. On 2015/10/22 at 18:09:23, dgn wrote: > Not true. This is working for me: net_junit_tests -f "*testGetNextAuthToken" Made the comment less assertive.
https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:127: pointing to "out_android". You can also use ```--output-directory``` to point On 2015/10/23 13:20:10, Mounir Lamouri wrote: > On 2015/10/22 at 18:09:23, dgn wrote: > > I think triple backtick make a new paragraph. > > No. > > > Did you check how the file is rendered on gitiles? > > I did try on gitiles in case of it was a gitiles oddities. I'm glad it's not :) But if you only want code markup, single backticks are still sufficient. https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:177: entire package name has to be used. On 2015/10/23 13:20:10, Mounir Lamouri wrote: > On 2015/10/22 at 18:09:23, dgn wrote: > > Not true. This is working for me: net_junit_tests -f "*testGetNextAuthToken" > > Made the comment less assertive. I think the full package name is matched against the filter, which would explain the behavior Nicolas is seeing ☺ https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... docs/android_test_instructions.md:164: . For example, adding a test to ```chrome_junit_tests``` requires to update Does this work, or do you get a space before the period?
Uploaded the file to go/dgn-md-tests/android_test_instructions.md for easier checking https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:127: pointing to "out_android". You can also use ```--output-directory``` to point On 2015/10/23 15:20:21, Bernhard Bauer wrote: > On 2015/10/23 13:20:10, Mounir Lamouri wrote: > > On 2015/10/22 at 18:09:23, dgn wrote: > > > I think triple backtick make a new paragraph. > > > > No. > > > > > Did you check how the file is rendered on gitiles? > > > > I did try on gitiles in case of it was a gitiles oddities. I'm glad it's not > :) > > But if you only want code markup, single backticks are still sufficient. It would also be consistent with the code in the rest of the file, that uses single backticks https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... docs/android_test_instructions.md:123: If you build in an output directory other than "out", you may have to tell nit: s/"out"/`out` and for a few other file names in the paragraph https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... docs/android_test_instructions.md:171: ninja -C out/Release chrome_junit_tests Why do you demo it with a release build? Aren't we supposed to do dev work on Debug?
Comments applied. PTAL. https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... docs/android_test_instructions.md:164: . For example, adding a test to ```chrome_junit_tests``` requires to update On 2015/10/23 at 15:20:21, Bernhard Bauer wrote: > Does this work, or do you get a space before the period? It works. https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... docs/android_test_instructions.md:171: ninja -C out/Release chrome_junit_tests On 2015/10/26 at 10:12:05, dgn wrote: > Why do you demo it with a release build? Aren't we supposed to do dev work on Debug? Consistency with the rest of the documentation. We can change the entire document if needed.
> https://codereview.chromium.org/1421613003/diff/20001/docs/android_test_instr... > docs/android_test_instructions.md:171: ninja -C out/Release chrome_junit_tests > On 2015/10/26 at 10:12:05, dgn wrote: > > Why do you demo it with a release build? Aren't we supposed to do dev work on > Debug? > > Consistency with the rest of the documentation. We can change the entire > document if needed. That's fine as it is, thanks. lgtm.
lgtm
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421613003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0fbd6cd844d535f80c8c4abaaad5ebe6f496dcc7 Cr-Commit-Position: refs/heads/master@{#356033} |
