Match index adds as well as base

src/IceTargetLoweringX86BaseImpl.h

Index: src/IceTargetLoweringX86BaseImpl.h
diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h
index b6b54e397d6fd1be0f638a84692485ca8810de91..d3c1d6c62d2721e45a722deced19f57cc8a04208 100644
--- a/src/IceTargetLoweringX86BaseImpl.h
+++ b/src/IceTargetLoweringX86BaseImpl.h
@@ -4524,9 +4524,11 @@ inline bool computeAddressOpt(Cfg *Func, const Inst *Instr,
     // Update Offset to reflect additions/subtractions with constants and
     // relocatables.
     // TODO: consider overflow issues with respect to Offset.
-    // TODO: handle symbolic constants.
     if (matchOffsetBase(VMetadata, Base, Relocatable, Offset, Reason))
       continue;
+    if (Shift == 0 &&

[Jim Stichnoth, 2015/11/04 21:25:11]

This "Shift == 0" is inconsistent with "(Shift == 0)" above.  Make them
consistent?  (I personally prefer without parentheses here.)

[sehr, 2015/11/04 22:44:43]

Removed, as suggested.

+        matchOffsetBase(VMetadata, Index, Relocatable, Offset, Reason))
+      continue;
     // TODO(sehr, stichnot): Handle updates of Index with Shift != 0.
     // Index is Index=Var+Const ==>
     //   set Index=Var, Offset+=(Const<<Shift)